When copying uncompressed images, compress on them on-the-fly #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chombourger This change is client-only, i.e. no need to update the backend. As I was not able to test the S3 path, please explicitly test this as well. |
|
Tested here over a low-speed link against a low-speed mtda device, and it works nicely. |
|
...except that zstandard here (0.13) does not work with |
|
I haven't looked at your changes yet but 1st: thank you! |
When copying an uncompressed image, we lightly compress the image on the fly with zstd on transfer. By that, subsequent zeros (holes) are automatically collapsed and not transferred, which can give a huge speedup on uncompressed images. Another advantage is, that zstandard can be decompressed with a very low overhead (e.g. compared to gz or xz) and is better suited for low-memory devices. closes: siemens#20 Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
fmoessbauer
force-pushed
the
fm/compress-on-the-fly
branch
from
5d943b7
to
5d41c9e
Compare
|
Together with @jan-kiszka , we checked if the |
chombourger
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copying an uncompressed image, we lightly compress the image on the fly with zstd on transfer. By that, subsequent zeros (holes) are automatically collapsed and not transferred, which can give a huge speedup on uncompressed images. Another advantage is, that zstandard can be decompressed with a very low overhead (e.g. compared to gz or xz) and is better suited for low-memory devices.
closes: #20