Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splitMapper into mappers #24

Closed
4 tasks done
Siemienik opened this issue Oct 2, 2020 · 0 comments · Fixed by #50
Closed
4 tasks done

Add splitMapper into mappers #24

Siemienik opened this issue Oct 2, 2020 · 0 comments · Fixed by #50
Assignees
Labels
good first issue Good for newcomers

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 2, 2020

Part of #21

TODO:

  1. Create file src/mappers/splitMapper.ts with function matches to type (v: string): string[]. Which for any input try to return only lower case string.
  2. reexport it in src/mappers/index.ts
  3. Prove that it works in unit test (create new one in tests/unit/mappers.test.ts)
  4. Describe it in Readme.md

test data provider:

const lowerCaseDp = [
  { inValue: '', expectedResult: [] },
  { inValue: 'asd', expectedResult: ['asd'] },
  { inValue: 'asd,', expectedResult: ['asd',''] },
  { inValue: 'asd,asd2', expectedResult: ['asd','asd2'] },
  { inValue: 'true,1, expectedResult: ['true','1'] },
]

Further (not in scope of this issue)

  • setting for separator
  • setting for itemMapper
@Siemienik Siemienik added the good first issue Good for newcomers label Oct 2, 2020
@lowkeypriority lowkeypriority mentioned this issue Oct 2, 2020
4 tasks
@Siemienik Siemienik changed the title Add splitMapper into mappers WIP: Add splitMapper into mappers Oct 4, 2020
@Siemienik Siemienik changed the title WIP: Add splitMapper into mappers Add splitMapper into mappers Oct 11, 2020
@Siemienik Siemienik mentioned this issue Oct 14, 2020
7 tasks
@Siemienik Siemienik self-assigned this Oct 15, 2020
Siemienik added a commit that referenced this issue Oct 17, 2020
…Add splitMapper itemMapper, Add tests+documentaion+samples
Siemienik added a commit that referenced this issue Oct 17, 2020
Issue #24: Add splitMapper, Add splitMapper customizable separator, Add splitMapper itemMapper, Add tests+documentaion+samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant