Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common mappers implementation #21

Closed
11 tasks done
Siemienik opened this issue Oct 2, 2020 · 2 comments
Closed
11 tasks done

Common mappers implementation #21

Siemienik opened this issue Oct 2, 2020 · 2 comments
Labels
accepted It is accepted to do

Comments

@Siemienik
Copy link
Owner

Siemienik commented Oct 2, 2020

The PR #20 refactor how the code is organised. Among others there was created new layer called mappers (src/mappers) and here I will describe how I plan to expand it.

Remark:

I marked this issue as good first issue because it contains list of simple and well described issues. Good practice is create one PR for one of these issues.

Actual

There is only file named index.ts with MAPPER_DEFAULT introduce in #19.

Expected

This should contains handy and the most popular mappers ready to use. The first mappers how I consider to do is:

For each mapper I'm going to create new issue.

Request for a mapper

This issue is great a place to propose mappers, so if you have any idea, write a comment.

@Siemienik Siemienik transferred this issue from Siemienik/xlsx-renderer Oct 2, 2020
@Siemienik Siemienik changed the title `Common mappers implementation Common mappers implementation Oct 2, 2020
@Siemienik Siemienik reopened this Oct 2, 2020
@Siemienik Siemienik added the good first issue Good for newcomers label Oct 2, 2020
@Siemienik Siemienik removed the good first issue Good for newcomers label Oct 4, 2020
@Siemienik
Copy link
Owner Author

Reviewing #45 I note that, we haven't listed here some useful mappers:

  • decimalMapper: has to define
  • integerMapper: Number.parseInt
  • dateMapper: transform date string into Date, same as new Date

I've just added it to the list above. I have to describe theirs test sets (data providers) and create issues.

@Siemienik
Copy link
Owner Author

Siemienik commented Sep 27, 2021

As the PR #192 was done, This issue is fully accomplished 🥇 Thanks to all contributors for your efforts 🍰

Thank you:
@Metastasis @Gontrum @machadolucasvp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It is accepted to do
Projects
None yet
Development

No branches or pull requests

1 participant