-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common mappers implementation #21
Labels
accepted
It is accepted to do
Comments
Siemienik
changed the title
`Common mappers implementation
Common mappers implementation
Oct 2, 2020
This was referenced Oct 2, 2020
This was referenced Oct 11, 2020
Closed
Reviewing #45 I note that, we haven't listed here some useful mappers:
I've just added it to the list above. I have to describe theirs test sets (data providers) and create issues. |
This was referenced Oct 13, 2020
Closed
Closed
As the PR #192 was done, This issue is fully accomplished 🥇 Thanks to all contributors for your efforts 🍰 Thank you: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The PR #20 refactor how the code is organised. Among others there was created new layer called
mappers
(src/mappers
) and here I will describe how I plan to expand it.Remark:
I marked this issue as
good first issue
because it contains list of simple and well described issues. Good practice is create one PR for one of these issues.Actual
There is only file named
index.ts
withMAPPER_DEFAULT
introduce in #19.Expected
This should contains handy and the most popular mappers ready to use. The first mappers how I consider to do is:
Some Text
=>SOME TEXT
Some Text
=>some text
'{prop:[1,2]}'
(string) =>{prop:[1,2]}
(object with array)val1,val2,val3
=>[val1,val2,val3]
123
(string) =>123
(number)Number.parseInt
0
=>false
new Date
regexMapper - true if matches to regexEDIT: for further developmentdecimalMapper: has to define**EDIT: ** for further development`For each mapper I'm going to create new issue.
Request for a mapper
This issue is great a place to propose mappers, so if you have any idea, write a comment.
The text was updated successfully, but these errors were encountered: