This repository has been archived by the owner on Dec 19, 2020. It is now read-only.
Improve tests #175
Merged
Improve tests #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t/regress.sh -> t/test_all.sh t/regress_util.sh -> t/test_util.sh
richardxia
approved these changes
Nov 12, 2019
| @@ -4,7 +4,14 @@ wit_repo='git@github.com:sifive/wit' | |||
| test_root=$(dirname $(perl -MCwd -e "print Cwd::realpath('$0')")) | |||
| wit_root=$(perl -MCwd -e "print Cwd::realpath('$test_root/..')") | |||
|
|
|||
| export PATH=$wit_root:${PATH} | |||
| if [[ -z "${WIT}" ]]; then | |||
There was a problem hiding this comment.
Is this WIT environment variable documented anywhere? Also, it's a little unintuitive that a variable named WIT should point to the directory containing the wit executable, not the wit executable itself. Should we consider setting WIT to the path of the executable itself, and defaulting to $wit_root/wit if it's unset?
There was a problem hiding this comment.
To be clear, this code doesn't require that WIT points to the directory containing wit, it also works for the executable itself, eg.
WIT=`which wit` ./t/test_all.sh
This will use the result of which wit.
Nothing about the tests are documented at all. I'll add a little blurb to the README-internals
Also use the new Makefiles rules in Travis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements:
Mainly motivated by wanting to test an install from a regular wit repo. You can now run the tests by setting environment variable
WITand it will use that wit instead: