AD-231 Add secure and http_only parameters support for cookies #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpicaza
reviewed
May 6, 2022
src/Sifo/Cookie.php
Outdated
| { | ||
|
|
||
| $domain ?: self::_initDomain(); | ||
|
|
||
| if ( 0 == $days ) | ||
| { | ||
| $result = setcookie( $name, $value, 0, self::$path, self::$domain ); | ||
| $result = setcookie( $name, $value, 0, self::$path, self::$domain, $secure, $http_only ); |
There was a problem hiding this comment.
Maybe you have to try to add a unit test for this method. Touch me if you want any help ;-D
There was a problem hiding this comment.
Thanks! I was on it, though it was a bit tricky because of class design. Finally I made tests working by adding some seams here and there. Please, take a look again! 😃
destebang
force-pushed
the
AD-231
branch
2 times, most recently
from
5346814
to
c6aa534
Compare
p0lemic
approved these changes
May 9, 2022
added 7 commits
May 27, 2022 11:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$secure = false, $http_only = falseso current behaviour is preserved.