Fix for non-working log_on_error due to bad scope of exceptions. Remove unused value from log_exception #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sighalt cannot add You as a reviewer |
sighalt
reviewed
Sep 19, 2022
| @@ -170,5 +170,5 @@ def __init__(self, message: str, *, logger: Optional[Logger] = None, | |||
| exception_format_variable=exception_format_variable) | |||
|
|
|||
| @staticmethod | |||
| def log(logger: Logger, log_level: Union[str, int], msg: str) -> None: | |||
| def log(logger: Logger, msg: str) -> None: | |||
There was a problem hiding this comment.
This change breaks the signature of the parent's log method. I rather have the unused argument.
| @@ -145,7 +145,7 @@ def _do_logging(self, fn: FunctionType, exception: Exception, *args: Any, **kwar | |||
| def execute(self, fn: FunctionType, *args: Any, **kwargs: Any) -> Any: | |||
| try: | |||
| return super().execute(fn, *args, **kwargs) | |||
| except Exception as e: | |||
| except BaseException as e: | |||
There was a problem hiding this comment.
Nice catch! Could you also change the type annotations of on_error and _do_logging, so they require BaseException instead of Exception?
You can check if everything is alright with mypy -p logdecorator.
Sure. I'll try to provide some unit tests according to your current approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I just recognized that @log_on_error throws an exception and doesn't give any log. So I found what's the problem - Exception, so I changed it to the BaseException. After that it catches the exception from function and outputs the log msg :)