Grafana sidecar for loading dynamically dashboards

[lzecca78]

Hi everyone 👋 !
i've implemented the k8s-sidecar that allow everyone to eventually inject in grafana whatever dashboard just creating a configmap in his namespace and labelling it with the label-key defined in the deployment. (look at README.md for more details)
This make massively easier to add/remove/modify new/exisisting dashboard without blood and tears.
Looking forward for your review!

[lnovara]

[lnovara]

Improve Grafana manifests

[phisco]

LGTM, but please disable the on-save-linter because it makes me mad to see so many lines changed just for a blank space or a tab.

[lzecca78]

@phisco the right way is the linter one. Once that all files will be linted, you'll never see any modifications 👨‍🔧

[phisco]

That’s the case if we all agree on a linter and/or spec, otherwise your linter will just keep removing spaces and white lines and mine (I don’t have one for yaml) could just keep adding them back 🤷🏻‍♂️ I love go fo having an official linter, that can be automated on save, yaml ones are just a matter of taste

[lzecca78]

@phisco i guess that is worst going on without linter because at least, linter has a standard, no linter means that anyone can do whatever it likes, that means "mess".

[ralgozino]

Now that the linting issue has been addressed and we've agreed on using police-man could you please add it to the pipeline @lzecca78 and let us know so we can move on with the review?
Thanks!

[lzecca78]

@ralgozino the modification that you are requesting will impact all the module monitoring that is the grafana dir plus everything else. This is imho out of scope with the aim of this PR. If you want, we can create an issue that will be converted in an activity, but i guess that is totally unrelated with this one.

[ralgozino]

as a minimum, I would say to apply police-man to the files that you are modifying in this PR, it is official since yesterday so we have to start enforcing it.
I don't know if it makes sense for the rest of the repo, I guess it depends on how many changes it will trigger, maybe the files are already mostly compliant with the linting rules.
Thoughts @angelbarrera92 @iknite @phisco ?

[angelbarrera92]

I included policeman in a couple of modules and it requires some time to fix (possible) issues. But we are talking about.... 30 min? So i think is worthy to include it in the PR.

If you don't want, i can do it for you. Just let me know Luca

[lzecca78]

Ok I will do it tomorrow!

[lzecca78]

@angelbarrera92 @ralgozino , linting done

[angelbarrera92]

@angelbarrera92 @ralgozino , linting done

Awe some job luca. Just one more thing (sorry for it) but you have to add a dependency between pipelines, meaning that if policeman does not pass, no other pipelines are executed. You can see an example here: https://github.com/sighupio/fury-distribution/blob/master/.drone.yml#L18-L19

Also, make sure you use v0.5.0 version for quay.io/sighup/e2e-testing-drone-plugin container image. It contains our latest modification to add labels to the vsphere instances ;)

Thanks!

[lzecca78]

@angelbarrera92 added dependencies and modified image version in .drone.yml

[angelbarrera92]

LGTM!