Search issue 494 #495
Merged
Search issue 494 #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigma67
reviewed
Dec 29, 2023
ytmusicapi/mixins/search.py
Outdated
| @@ -233,7 +233,8 @@ def parse_func(contents): | |||
|
|
|||
| def get_search_suggestions(self, | |||
| query: str, | |||
| detailed_runs=False) -> Union[List[str], List[Dict]]: | |||
| detailed_runs=False, | |||
| include_history=False) -> Union[List[str], List[Dict]]: | |||
There was a problem hiding this comment.
There's no need to make this an option, is there? We can just make this the default and remove the option
What's more relevant is a flag to determine whether a suggestion originates from the history. Is this discernible with the current solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #494 and adds option to return historical items, ignored by default.