Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

809: Email created from "Report a bug" hyperlink : free from + signs #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GimhaniU
Copy link
Contributor

These strings were encoded using URL.encodeQueryString() which causes spaces to be replaced with + signs. This pull request removes this and directly add the string to mail object.
fixes 809.

@GimhaniU GimhaniU changed the title 809: Email created from "Report a bug" hyperlink : freed from + signs 809: Email created from "Report a bug" hyperlink : free from + signs Apr 15, 2017
@GimhaniU
Copy link
Contributor Author

However, this fix causes newlines too removed.

@osarrat
Copy link
Member

osarrat commented Aug 29, 2017

Hi @GimhaniU !

I hope that you are fine and well!

Much time later, I've tested your Pull Request, and I found that it does fix the issue #809, but it creates another issue: there is no more any carriage return in the email template.
In order to merge your piece of work, this side-effect should also be fixed. Do you think you can work on it ?

Best,

Olivier.

bugreportemailmissingcarriagereturns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants