Add unit test for github.license/github.licenses

[itsmemattchung]

We need a unit test in tests/unit/test_github.py to assert the correct request is made.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/30400727-add-unit-test-for-github-license-github-licenses?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github).

[sigmavirus24]

👍

[sourabhmasade]

Can you please provide more details on what tests needs to be added?
I do see tests/unit/test_licenses.py already present. So need more inputs whether tests needs to be added to this file instead of test_github.py?

[itsmemattchung]

Can you please provide more details on what tests needs to be added?
I do see tests/unit/test_licenses.py already present. So need more inputs whether tests needs to be added to this file instead of test_github.py?

Hey @sourabhmasade ,
Every method that makes an API call to github needs a unit test that verifies the request is made properly. Here is an example:

https://github.com/sigmavirus24/github3.py/blob/develop/tests/unit/test_github.py/#L171-#L174

We need a unit test for the GitHub object since we have method(s) that make calls to retrieve license(s).

[itsmemattchung]

hey @sourabhmasade ,
Let me know if you need any help with creating this unit test.

[mlkrueger]

If @sourabhmasade is not going to be able to work on this I would be willing to take a shot.

[itsmemattchung]

If @sourabhmasade is not going to be able to work on this I would be willing to take a shot.

@sourabhmasade may already be tackling this so let's give them until this weekend to respond. If not, I'd say give it a shot.

[mlkrueger]

Sounds good.

[sourabhmasade]

Hey @itsmemattchung i am working on this, I need one more week unit test is in process.

[sigmavirus24]

@sourabhmasade take your time :)

[sigmavirus24]

@MLKrueger1987 let's find you a different issue to work on :)

[itsmemattchung]

Hey @sourabhmasade , I'm just checking in. Do you need any help with the unit test?

[jubrilissa]

Hi @sourabhmasade have u been able to work on it. if not maybe i should give it a shot.

[sigmavirus24]

@andela-ijubril please do. I don't think @sourabhmasade has made much progress on this.