add [optional] update kwarg to create_tag() #725
Conversation
|
This PR is based on top of #724 |
If True, this will force the update of an existing annotated tag. Defaults to False.
jhoblitt
force-pushed
the
feature/create_tag_update
branch
from
f335aec
to
904b7de
Compare
|
Repushed to fix flake8 warning. |
| 'email': 'example@example.com', | ||
| 'date': '2015-11-01T12:16:00Z', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Unless I'm missing something, this doesn't validate that the call went through update_ref instead of create_ref. Is there a way you could validate that instead?
There was a problem hiding this comment.
Why does the internal call chain matter? This is a behavioral test that verifies that the given input produces the desired result.
There was a problem hiding this comment.
Because as a unit test, we want to ensure the right decision path is used, and that the code path you've added is exercised. We should at least see patch called instead of post.
|
This isn't mergeable. I think I'd be happy to merge a new PR that adds the |
If True, this will force the update of an existing annotated tag. Defaults to
False.