Add support for Draft PR status in responses #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds response data support for the `draft` status of a pull request. This was recently [added](https://github.blog/2019-02-14-introducing-draft-pull-requests/) to the platform and API. A PullRequest can be marked as a `draft` which will prevent merging and delay triggering automatic pull request reviews from `CODEOWNERS`. Support for receiving the data is still in preview so new headers have to be littered throughout the codebase. Resolves: sigmavirus24#926
|
In a nice bit of meta, I've marked this PR as a draft! I was able to get unit tests to pass locally, however failures might be being masked by a fallback setting on All the relevant integration test data needs to be updated to, and tests added to ensure that we ARE finding that a PR is in draft mode when we should be. |
Co-Authored-By: omgjlk <omgjlk@github.com>
|
Build succeeded (third-party-check pipeline).
|
|
Would love to see this PR get merged. |
|
I believe this is supported in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds response data support for the
draftstatus of a pullrequest. This was recently
added
to the platform and API. A PullRequest can be marked as a
draftwhichwill prevent merging and delay triggering automatic pull request reviews
from
CODEOWNERS.Support for receiving the data is still in preview so new headers have
to be littered throughout the codebase.
Resolves: #926