Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make delete only need to expand vars in name #13

Merged
merged 1 commit into from
Aug 16, 2022
Merged

make delete only need to expand vars in name #13

merged 1 commit into from
Aug 16, 2022

Conversation

scott-cotton
Copy link
Member

No description provided.

foxish
foxish approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@foxish foxish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I still think we should just encourage people to use delete <name> over delete -f --set <name> in our docs.

@scott-cotton scott-cotton merged commit c391d7a into main Aug 16, 2022
@scott-cotton scott-cotton deleted the delete-defs branch August 16, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxish foxish foxish approved these changes

@jmsktm jmsktm Awaiting requested review from jmsktm

@enisoc enisoc Awaiting requested review from enisoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scott-cotton @foxish