Merge pull request #529 from ahfa92/main

fix delaystat overflow when changing retain limit
signal18 · Jan 3, 2024 · 86f3c1e · 86f3c1e
2 parents 7503e94 + 73e4ee9
commit 86f3c1e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/cluster/cluster_stat.go b/cluster/cluster_stat.go
@@ -65,8 +65,8 @@ func (sds *ServerDelayStat) UpdateDelayWithRotate(s int64, limit int) {
 	sds.Rotated = sds.DelayHistory[0].DelayStat
 
 	//Rotate Stat if exceed limit
-	if len(sds.DelayHistory) == limit {
-		sds.DelayHistory = sds.DelayHistory[1:]
+	if len(sds.DelayHistory) >= limit {
+		sds.DelayHistory = sds.DelayHistory[(len(sds.DelayHistory)-limit)+1:]
 	}
 
 	sds.ResetCurrentStat() //Reset Current Stat
@@ -117,8 +117,8 @@ func (sds *ServerDelayStat) UpdateSlaveErrorWithRotate(limit int) {
 	sds.Rotated = sds.DelayHistory[0].DelayStat
 
 	//Rotate Stat if reach limit
-	if len(sds.DelayHistory) == limit {
-		sds.DelayHistory = sds.DelayHistory[1:]
+	if len(sds.DelayHistory) >= limit {
+		sds.DelayHistory = sds.DelayHistory[(len(sds.DelayHistory)-limit)+1:]
 	}
 	sds.ResetCurrentStat() //Reset Current Stat