Delay average statistic #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svaroqui
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Could we organize code to put most functions in cluster_stat.go file !
|
Hi @svaroqui, I already updated the code. Kindly check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding delay average statistics for failover weighting. Already got the statistic, but still waiting for the weighting calculation. Kindly suggest the weighting algorithm.
values:
delay: average delay
delayCount: counter of lag more than 0 seconds occured
slaveErrCount: counter of slave error
counter: total counter
if we want to see percentage of delay count we can do delayCount / counter and so does with slave err percentage slaveErrCount
based on the logic we should pick the lowest value available.