Adds content descriptions for in-call buttons #11977
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
Fixes #9774
It seems like #9794 would have also fixed #9774, however it seems like #9794 has been closed for some time and at this point would require resolving some merge conflicts in order to ship. Normally I would have asked whether I could help improve that PR instead of making a new one, however I didn't realize that #9774 had already been addressed until after debugging the issue and writing the code. 馃槄 Hopefully my PR is ok/helpful! 馃檹馃徎
Previously, when in a WebRTC call and using Talkback, the dailer buttons would read, from right to left:
now, when in a WebRTC call and using Talkback, with video and audio enabled, the dailer buttons will read (from right to left):
when in a WebRTC call and using Talkback with video off and audio muted, the dailer buttons will read (from right to left):
I had to create a new "unmute" string in order to accommodate the way that the button currently works, but hopefully this will be a quick one to translate because the string already exists elsewhere in Signal. :) I think that the double negatives could be a bit tricky and might recommend swapping how the button announces itself, but that seemed like outside the scope of this PR.
I wasn't able to test the speakerphone button in Talkback/it seems to appear somewhat non-deterministically on my phone, but I have a high confidence that that button will work out well? 馃槄 馃檹馃徎
I do think that it would likely be a better user experience if the "flip" button read "flip to front camera" or "flip to back camera" but it looks like getting the camera state into
WebRtcCallView
may be fairly complicated and above my skills at this time. As it seems like this issue has been open for a long time, maybe it's helpful to merge the initial PR, then have someone else follow up later?