Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10973 You can add blocked users to groups #11979

Closed
wants to merge 1 commit into from

Conversation

Sgn-32
Copy link
Contributor

@Sgn-32 Sgn-32 commented Feb 9, 2022

Contributor checklist

  • Virtual Pixel 2, Android 11
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Fixes #10973 and some more for blocked recipients.

When a contact is blocked, don't show in the ConversationSettingsFragment:

"disappearing message"
"add to system contacts"
"add to a group"

The menu item "Conversation settings" was also made functional again, when a recipient is blocked.
The menu item was shown, but not functional, when conversation "isInMessageRequest".

Now menu item "Conversation settings" is hidden when conversation is in message request, but not blocked.


signal-2022-02-09-193624_001

signal-2022-02-09-193624_002

@stale
Copy link

stale bot commented Jun 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 28, 2022
@Sgn-32 Sgn-32 changed the title Fix #10973 You Can Set Disappearing Messages on Blocked Users Fix #10973 You can add blocked users to groups Jun 29, 2022
@Sgn-32
Copy link
Contributor Author

Sgn-32 commented Jun 29, 2022

So the setting for disappearing messages are shown but disabled. But still possible to add a blocked user to groups.

  • block a user
  • go to the main conversation list screen
  • click on the blocked user's avatar/icon
  • a little modal with come up with some actions for that user.
  • in that modal click the avatar/icon of the blocked user again to take you to the conversation settings screen for that user

@stale stale bot removed the wontfix label Jun 29, 2022
@cody-signal
Copy link
Contributor

This will be in 5.43

@Sgn-32 Sgn-32 deleted the Fix_#10973 branch July 12, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

You Can Set Disappearing Messages on Blocked Users
2 participants