Enable media message forwarding

[McLoo]

This is a stew mainly of #2886 with some nice chunks of #2236

• Tested forwarding to existing as well as new (group-)convos.
• Tested on a 5.0.2 device and KK emulator. Couldn't get a play service enabled GB emu - can't use a new TS installation without play services... 😞

All media works fine as well as text and text + media.

[jeremymasters]

Does this also fix selection of media messages? In 2.16.3 I can't long-press the image to select it. I have to long-press in the open space beside it.

[2-4601]

@jeremymasters See: #2333, #2488, #2648 (PR).

[rhodey]

hey @McLoo, I just checked out this PR, rebased it with master, and ran some tests. every time i try to forward an image message the image preview is the red error icon, tapping send results in no image being sent.

can you rebase this and let me know if you can reproduce? I tested this on my Nexus 5 running stock Android 5.1 Lollipop, rebased into f72cd5b

[McLoo]

@rhodey then you collabs broke it 😉

Will check out. The magic is in those lines:

if (isAuthorityPartDb(uri))
  part.setDataUri(PartAuthority.getPublicPartUri(uri));
else
  part.setDataUri(uri);

Had the triangle before, when not using getPublicPartUri?!

Edit: this occurred only for images...

[McLoo]

@rhodey tested on CM 12.1 with 2.18.1
Still works for me. Can you post a debug log? 😁

[rhodey]

hey @McLoo, I just rebased this with 2.18.1 and tested on my stock 2.3.6 Gingerbread device & my stock 4.4.2 device, both work great. my nexus 5 is my daily use phone, I keep my actual install of TextSecure on there, so when I want to test a new build of TS on that device I have to alter the application ID and some other package names in the build.grade and AndroidManifest.xml file-- basically the app that I test on this device is not the exact app that I should be testing.

so, in conclusion it probably doesn't work on my nexus 5 for reasons related to me changing the application ID and package names. interestingly nothing was actually caught in the log file related to the error icon showing up. this PR looks good to me and has tested well, if we could get someone to test this on a stock lollipop device I'd be super confident in merging it.

👍

[McLoo]

I'm thinking of assertMediaSize everytime - not only if not isAuthorityPartDb.
There could be changes for media size, after the media went into the DB?!

(assertMediaSize should probably move into sendMediaMessage, once bigger files are allowed for push)

[McLoo]

Finally I found someone who was willing to try this PR on his daily use phone. 😬
Titanium Backup works great if you have to juggle with builds while keeping data.

So: on my Sony Z1 compact 5.0.2 (rooted) this also works fine. Couldn't test media playback though cause of #3436 works with PR 3437

[moxie0]

this is intentionally private

[McLoo]

@moxie0 comments addressed

[McLoo]

rebased

[McLoo]

rebased. reduced refactoring.

[McLoo]

😠 temporarily closing til I'm happy with GIF-detection

getting the MimeType isn't very funny for internal media :/