Enable media message forwarding

[McLoo]

For images this works without handing the content type through the intents, as it is set to ContentType.IMAGE_JPEG hardcoded.
This also unifies AudioSlide's and VideoSlide's constructPartFromUri as they were edited anyway.

Fixes #1362 and #1914

I strongly recommend merging #2234 and #2232 as without them forwarding message is not funny...

[mcginty]

I'm thinking we should just change ConversationActivity to accept a DRAFT_TEXT, DRAFT_MEDIA, and DRAFT_MEDIA_TYPE, and have it determine the slide type from the media type passed in.

[McLoo]

@mcginty I like how you use the word 'just' 😀

[McLoo]

Works fine so far.
Maybe some prettifying is needed... but hey a minus diff

[McLoo]

fixed non media forward :)
EDIT: and now we make use of ContentType.java

[McLoo]

I are hates git burgerz
grilled this PR. for now :/

fixed. git push -f origin HEAD:ff_av is thy friend

[McLoo]

needs heavy refactoring after #2331

[rhodey]

@McLoo I started looking into this a few days ago before noticing that you already had a pull open. With some of the updates that have been included since you're pull was opened this seems to be a lot easier now.

In ConversationFragment.handleForwardMessage() you should be able to add a check for message.isMms(). Then if this is true call MediaMmsMessageRecord.fetchMediaSlide() and pass in a listener that onSuccess(Slide result) starts ConversationActivity with one of the following extras ConversationActivity.DRAFT_IMAGE_EXTRA, ConversationActivity.DRAFT_AUDIO_EXTRA, or ConversationActivity.DRAFT_VIDEO_EXTRA.

The MediaMmsMessageRecord.fetchMediaSlide() call is technically asynchronous but MediaMmsMessageRecord's SlideDeck should have definitely been resolved by now and we're already assuming this is the case here. If the listener gets an onFailure() call just treat it as a forwarded text-only message instead.

I defer to @mcginty for his ImageSlide and SlideDeck expertise.

[McLoo]

@rhodey if you're fine with it, you can PR this as a new one. I'm a bit busy these days. If not... well I guess there's always some time around 😀

Still don't know if this should be touched again before #2331 #2792
Edit: though there should be less changes if we just don't implement DRAFT_MEDIA,and DRAFT_MEDIA_TYPE as proposed by @mcginty

[McLoo]

@rhodey just checked your fix. You'll need to do some content type handling. I admit I don't understand it completely, but the changes to AudioSlide and VideoSlide where necessary to avoid crashes.
Don't think yours will work out of the box.

[rhodey]

@McLoo thanks for the tip! I hadn't tested that POC branch for audio and video yet, will check it out :)

[McLoo]

@rhodey is fixing this anywhere on your agenda? I might have a second look, will be another PR for sure. sooo many changed 😮

[rhodey]

@McLoo it is not on my todo list but probably my todo-if-everything-else-magically-works-out list. I was also waiting to let the Glide refactor mature, seems like things are getting pretty stable with that and last time I checked all the changes made things significantly easier-- don't let me stall you on that if you feel like starting again :)