Add Settings.isNotificationGroupingSupported

See: electron/electron#11189
signalapp · May 4, 2018 · f20e0d3 · f20e0d3
1 parent c742212
commit f20e0d3
Show file tree

Hide file tree

Showing 2 changed files with 67 additions and 0 deletions.
diff --git a/ts/test/types/Settings_test.ts b/ts/test/types/Settings_test.ts
@@ -68,4 +68,66 @@ describe('Settings', () => {
       });
     });
   });
+
+  describe('isNotificationGroupingSupported', () => {
+    context('on macOS', () => {
+      beforeEach(() => {
+        sandbox.stub(process, 'platform').value('darwin');
+      });
+
+      afterEach(() => {
+        sandbox.restore();
+      });
+
+      it('should return true', () => {
+        assert.isTrue(Settings.isNotificationGroupingSupported());
+      });
+    });
+
+    context('on Windows', () => {
+      context('version 7', () => {
+        beforeEach(() => {
+          sandbox.stub(process, 'platform').value('win32');
+          sandbox.stub(os, 'release').returns('7.0.0');
+        });
+
+        afterEach(() => {
+          sandbox.restore();
+        });
+
+        it('should return false', () => {
+          assert.isFalse(Settings.isNotificationGroupingSupported());
+        });
+      });
+
+      context('version 8+', () => {
+        beforeEach(() => {
+          sandbox.stub(process, 'platform').value('win32');
+          sandbox.stub(os, 'release').returns('8.0.0');
+        });
+
+        afterEach(() => {
+          sandbox.restore();
+        });
+
+        it('should return true', () => {
+          assert.isTrue(Settings.isNotificationGroupingSupported());
+        });
+      });
+    });
+
+    context('on Linux', () => {
+      beforeEach(() => {
+        sandbox.stub(process, 'platform').value('linux');
+      });
+
+      afterEach(() => {
+        sandbox.restore();
+      });
+
+      it('should return true', () => {
+        assert.isTrue(Settings.isNotificationGroupingSupported());
+      });
+    });
+  });
 });
diff --git a/ts/types/Settings.ts b/ts/types/Settings.ts
@@ -4,3 +4,8 @@ const MIN_WINDOWS_VERSION = '8.0.0';
 
 export const isAudioNotificationSupported = () =>
   OS.isWindows(MIN_WINDOWS_VERSION) || OS.isMacOS();
+
+// Using `Notification::tag` has a bug on Windows 7:
+// https://github.com/electron/electron/issues/11189
+export const isNotificationGroupingSupported = () =>
+  !OS.isWindows() || OS.isWindows(MIN_WINDOWS_VERSION);