Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Contact #1133

Closed
andrewbanchich opened this issue Apr 18, 2017 · 41 comments
Closed

Delete Contact #1133

andrewbanchich opened this issue Apr 18, 2017 · 41 comments

Comments

@andrewbanchich
Copy link

@andrewbanchich andrewbanchich commented Apr 18, 2017

contacts that signal finds that were once in my contacts list are appear in the signal desktop app once those contacts join. however, they had been deleted from my google contacts list a long time ago. there is no way to remove them from the Signal desktop app. please update so i can remove these contacts.

@piusg
Copy link

@piusg piusg commented Apr 18, 2017

Don't hold your breath. Signal Desktop conversation and contact management has got a loooooong way to go.

I had been begging for this very issue to be looked at months ago. Only responses I've ever gotten were "Here, try this long, convoluted thing that fundamentally changes the way you manage your contacts" or, more often than not, shrug sorry.

Evidently the ability to share animated dancing kitten GIFs free from snooping was a higher priority than archiving or deleting disused conversations like, oh, EVERY OTHER CHAT CLIENT EVER. The other chat desktop client teams clearly have implemented those features in their proper order.

Just be happy you can do it on the mobile client. At least that works.

@suisea
Copy link

@suisea suisea commented May 8, 2017

+1. kinda not cool to see exes whose names start with "a" every time i open signal desktop.

@jm3
Copy link

@jm3 jm3 commented Jun 1, 2017

Here's the simple workaround for this that I found:

  1. First, delete the contact from your OS address book. If your phone and desktop's address books don't sync, I assume you may need to delete the contact from both.
  2. in Signal Desktop, after clicking the offending contact, just click Delete Messages.
  3. the UI does not refresh in any intuitive way — this actually triggers a display bug where the deleted contact's avatar still appears in your contact list, but the conversation displayed now corresponds to your conversation with OFFENDING_BUDDY_PLUS_ONE.

But upon relaunch, the bad contact will be gone from your contacts list. 👻

@scottnonnenberg
Copy link
Contributor

@scottnonnenberg scottnonnenberg commented Jun 2, 2017

@jm3 Can you provide some screenshots and logs for that off-by-one situation?

@jm3
Copy link

@jm3 jm3 commented Jun 4, 2017

@scottnonnenberg hm, i guess not! i tried to reproduce it and this time it worked as expected ¯_(ツ)_/¯

UPDATE: I've recorded a screencast of the deletion and the above bug, and sent it privately via DM, since it contains personal info via the contact list. hopefully it helps.

@dharness
Copy link

@dharness dharness commented Jun 9, 2017

I think the solution listed by @jm3 is actually reasonable for a contact you no longer want to keep. But why should my list of chat-contacts be the same as my list of OS-contacts or phone-contacts?
90% of contacts I don't wish to chat with via Signal, even if they had it.

What if we just had the ability to "hide" a contact instead? We would keep them as a contact, just not display them in the left menu? Or rather, all contacts are hidden until you engage with them or add them.

@jm3
Copy link

@jm3 jm3 commented Jun 15, 2017

@scottnonnenberg @dharness oh man, it's worse than I realized — now the deleted contact is back in the Signal contacts list, again. Super annoying, and weird since they're fully deleted from my address book. If I had to guess, I'd say Signal is attempting to sync between mobile and desktop, and getting it wildly wrong, so that whenever I delete from the one, the other re-syncs it back? No idea.

One of the weirdest things is, I've never messaged this person, yet they appear in between two other contacts who I've messaged this week.

So not only is Signal incorrectly stopping me from deleting a contact, AND incorrectly re-inserting that contact after removing them, but they're sorting the (contact that should be deleted) in the wrong order. So sort of a triple fail.

@pahakalle
Copy link

@pahakalle pahakalle commented Jun 22, 2017

I kinda like to send messages to myself.

@jm3
Copy link

@jm3 jm3 commented Jun 22, 2017

It seems like the backlog on these basic blocking-and-tackling features is pretty deep. Is there a separate thread being worked on regarding a block feature? That would solve this, so maybe this is a dupe of that?

@scottnonnenberg
Copy link
Contributor

@scottnonnenberg scottnonnenberg commented Jun 27, 2017

@jm3 You can block users in the mobile apps, and that blocked state will be sync'd to your linked desktop apps. It will prevent you from sending messages to them, as well as prevent any incoming messages from them from showing up.

@jm3
Copy link

@jm3 jm3 commented Jun 27, 2017

@scottnonnenberg sadly that doesn't work because the user only appears in Desktop Signal. I've already deleted them from mobile. Every time I launch Desktop Signal, they appear, and then I have to select "Restart Signal" to make them disappear. Comical. Syncing also does not fix this.

@breznak
Copy link

@breznak breznak commented Nov 15, 2017

Another workaround should be to Archive the conversation (on mobile for now), that would not show up your exes

@scottnonnenberg
Copy link
Contributor

@scottnonnenberg scottnonnenberg commented Nov 22, 2017

v1.0.39 is released, and when you select to 'delete messages' for a conversation, that conversation will also be removed from the left pane.

@jayotto
Copy link

@jayotto jayotto commented Apr 28, 2018

Really, all I need to do is get my ex-wife's name out of my signal contact list. She is not in any other contact list, not on iOS, MacOS, Google, etc. Has been deleted for years. At t his point I have a handfull of people I know who actually use Signal. At this point I dread notifications of incoming messages from any of them, because I know that that tortuous demon's name is going to show up on the top of the contact list. I would rather cut off an arm than use Signal, because of THIS ISSUE!

Please fix this bug, so I can get that monster out of my life.

None of the workarounds listed above work for me, even temporarily.

@piusg
Copy link

@piusg piusg commented Apr 30, 2018

@gasi-signal
Copy link
Contributor

@gasi-signal gasi-signal commented May 1, 2018

@jayotto & @piusg I am sorry you are still seeing people in your contacts that you do not wish to be there. Have you tried the ‘Delete messages’ workaround outlined above: #1133 (comment)? Or are you still receiving messages from that person? If so, have you tried blocking that contact on Signal iOS or Signal Android?

Please provide us with more information so we can investigate this issue.

@andrewbanchich
Copy link
Author

@andrewbanchich andrewbanchich commented May 1, 2018

@gasi-signal Is there a reason this is a very difficult bug to fix? I would not think simply being able to remove a contact from being shown would be so hard that we have to use workarounds instead of just fixing the bug.

@lschwetlick
Copy link

@lschwetlick lschwetlick commented May 2, 2018

I also have this problem, only that in my case it was my number which was accidentally saved as a contact with a different name. Every once in a while, in a place where it should say my name, like in the new quoting feature, it sais the name of this contact that was erroneously associated with my number. Deleting the contact from my contact book has not worked, neither has deleting all messages (there are none). Does Signal have an internal record of contacts or personal information that I can edit?

@UserX404
Copy link

@UserX404 UserX404 commented May 2, 2018

I noticed the same issue in a group where one person had stopped using signal.
This person has also completed the unregister procedure but is still in my contacts. I'm not able to delete it. In contacts-app I get the notification read-only contacts can only be blended out.

@jayotto
Copy link

@jayotto jayotto commented May 3, 2018

@gasi-signal I've deleted all messages, and deleted all contact information on iOS and MacOS. I'm not trying to block messages (I'm not receiving any), just trying to remove the mysterious erroneous ghost contact that keeps showing up in the Signal contacts list).

Thanks

@gasi-signal
Copy link
Contributor

@gasi-signal gasi-signal commented May 3, 2018

@jayotto The Signal Desktop app doesn’t pull contacts from macOS, but rather syncs them from your mobile device, i.e. iOS in your case. I created a little animation for how to delete a contact from the left-hand side of your Signal Desktop app:

delete-contact

That should remove the contact from the contact list until you or they write a new message into that conversation. If that contact reappears, please let us know as it might indicate your mobile device sent it to you again.

@andrewbanchich As for Is there a reason this is a very difficult bug to fix?: We are only two full-time developers on Signal Desktop and therefore have competing priorities in terms of keeping our features up-to-date with the other clients (quoted replies, media gallery, etc.), fixing high-impact bugs (disappearing messages not disappearing, other potential security issues etc.) that bugs like this—very annoying but not high-impact (vs. security bug) and with a workaround—often fall behind. For that we apologize. We are working on improving our process and infrastructure to make it easier to address bugs like this more easily in the future.

@gasi-signal gasi-signal changed the title no way to remove contacts Delete Contact May 3, 2018
@kyeotic
Copy link

@kyeotic kyeotic commented Jun 1, 2018

@gasi-signal Do you take PR's for this kind of stuff? I would love to contribute

@scottnonnenberg-signal
Copy link
Member

@scottnonnenberg-signal scottnonnenberg-signal commented Jun 1, 2018

@tyrsius We have a really high bar for PRs, but yes we do merge them in. The difficulty with this one, of course, is that it will change the user experience, and there's no single correct solution. We'll want to be in communication with you as you consider potential designs.

@datamafia
Copy link

@datamafia datamafia commented Jun 1, 2018

Can I question the commitment to privacy for a moment? Consider how my most private app is allowing unwanted people (spammers) to sneak in and potentially contact me:

I have a collection of blocked numbers, some are exes, others are people I never want to talk to again so I keep them in contacts to ALWAYS IGNORE. But the real privacy threat is robo-call phone numbers. So many robo-call phone numbers are showing up 'registered' on signal. I have over 100 recorded (and blocked) but there are many on Signal, allowed to contact me when I do everything possible to deny access.

I don't like this sitting out there. A conversation should be a 2+ person accept cycle, not a "push because I have the number" scenario as it smells right now, ripe for abuse and automation.

I use apps like Signal because I value privacy and wish to keep the greater spam of life at bay. I also support any effort to stifle or slow down the ability of my own government to spy on law abiding citizens. #justSaying

I see the use of phone number(s) as a crutch and pending security fail for apps like this where no legitimate alternative (?) is available or even in serious discussion. My phone number is 90%+ robo-calls. I don't want a phone number anymore and am ready to slide over to signal or similar type of operation. Signal is not ready to operate on that level, only a small part of the problem is solved, and until I can drop the use of a phone number (I use burner numbers to protect myself, I know what can be done) I feel that signal is still tethered negatively to a reality that is a far too insecure. Phone numbers provide a keen method to track and create unwanted meta-data breadcrumbs. I can cite many issues in the telecom infrastructure as well as current HTTPS/etc standards where meta-data is in the open. We count on services like Signal to provide privacy on all levels, phone number dependency is a smudge on what should be something pretty shiny.

I appreciate the app, features not found elsewhere, and the suite in general. I also appreciate the underlying crypto but reading the thread here I feel that the underlying development is tone deaf to the desire and need of people wanting to control communication access.

A note for @gasi-signal - I appreciate your work and am also an overworked dev. Grok this: I deleted Signal desktop and Mobile, re-authed on mobile, then re-linked on desktop today (all up to date versions). The contact list was NOT in mobile (blocked contact access) but was present (still, after deletion. re-install, and relink). The cycle I took to delete unwanted contact noise underscores a security issue. Either there is a remnant list of data on desktop I missed on uninstall, or there is a lack of proper hashing and validation of clients allowing the desktop to pick up on artifact data. I have addressed this same situation with other apps, this is a simple and easy to exploit attack on personal information. Please consider the ramifications of not securing, uninstalling, and serializing conversations and devices correctly. The operation tells me that this data is not secure or encrypted correctly and lacks the expected serialization to an installed application.To talk more on this please email me via my Git address, never discount user error or the stupidity of people using your service/app. thanks

@kyeotic
Copy link

@kyeotic kyeotic commented Jun 1, 2018

@datamafia That is a legitimate concern, but you should really open a separate issue for it. Its not going to be easy to have both of those discussions in this thread, especially considering the fundamental design nature of your issue.

@baack
Copy link

@baack baack commented Jul 16, 2021

Wow, 4 years and basic privacy issues like that are still not fixed.
Is deleting contacts too advanced feature for instant messenger in 2021?

@baack
Copy link

@baack baack commented Jul 16, 2021

And it's not possible to rename contacts too without providing access to contacts on the phone. And even when contacts permission is not provided - the app gets the contact name somehow and does not allow it to change.
Signal is worse in basic features than IM applications from 1990th.

@lschwetlick
Copy link

@lschwetlick lschwetlick commented Jul 16, 2021

@baack I agree that this is an important issue to fix, but come on, since when is bashing it the way to go? Let's be constructive here!

@baack
Copy link

@baack baack commented Jul 16, 2021

@lschwetlick sorry, but I'm in frustration, read the thread - people suffer with annoying contacts removed years ago. The issue is not moving forward for at least 4 years.

The basic feature to rename or delete contact is not available in Signal! Not on desktop nor on mobile app.
Isn't it ridiculous?
It makes Signal look like application that has 4 users, not millions.

since when is bashing it the way to go?

Maybe since politer ways apparently have not worked for many years now?

@synaptiko
Copy link

@synaptiko synaptiko commented Jul 16, 2021

@baack I think this would be a good read for you: https://drewdevault.com/2019/01/01/Patches-welcome.html

It’s important for users to remember that they’re not entitled to anything other than the rights laid out in the license. You’re not entitled to bug fixes or new features - you’re empowered by free software to make those changes yourself.

=> https://github.com/signalapp/Signal-Desktop#contributing-code

@baack
Copy link

@baack baack commented Jul 16, 2021

@synaptiko

  1. I also participate in F/LOSS (not with this github account) and understand how it works and how ungrateful it can be.

  2. I'm entitled to my opinion and can tell it.

  3. I won't contribute to signal-desktop because I don't have high enough expertise in javascript/typescript (yes, Signal has javascript wrapped with chromium browser as main desktop version of messenger, slow and heavy).

  4. Consider this - sometimes it's better to do nothing for others than to do something but badly.
    It's not an easy idea to comprehend, actually. Because many think that doing something is always better.

For example, a bad signal-desktop application that for 5 years has no basic features (rename/delete contact) and can't have tray icon that opens app on single mouse click IS WORSE than having no signal-desktop application at all.

  • Because if there is no bad signal desktop application at all - no one would use Signal in the first place and no people would suffer (read the thread above). Or someone will create a proper one, at least there is a chance.

  • But if there is a bad signal desktop application then it's probable that no one will ever make a proper one and more users will suffer after deciding to use Signal because they expected it to have a desktop application that is as good as mobile one.

@kyeotic
Copy link

@kyeotic kyeotic commented Jul 16, 2021

  • I also participate in F/LOSS (not with this github account) and understand how it works and how ungrateful it can be.

Do you also have a romantic partner from another high school?

I'm entitled to my opinion and can tell it.

That goes two ways.

I won't contribute to signal-desktop because I don't have high enough expertise in javascript/typescript (yes, Signal has javascript wrapped with chromium browser as main desktop version of messenger, slow and heavy).

You're happy to bash it though.

Consider this - sometimes it's better to do nothing for others than to do something but badly.
It's not an easy idea to comprehend, actually. Because many think that doing something is always better.

Apply this thinking to your comments

  • Because if there is no bad signal desktop application at all - no one would use Signal in the first place and no people would suffer (read the thread above). Or someone will create a proper one, at least there is a chance.
  • But if there is a bad signal desktop application then it's probable that no one will ever make a proper one and more users will suffer after deciding to use Signal because they expected it to have a desktop application that is as good as mobile one.

This complaint rings hollow when you're previous complaint was

The basic feature to rename or delete contact is not available in Signal! Not on desktop nor on mobile app.

So it's not that the desktop version is bad, or missing features from the mobile app. No version has this ability. Its not that expectations from mobile are met with surprise on desktop.

No, it boils down to entitlement. You use other apps that have this feature, or that feature, and you expect Signal to live up to these expectations. When it doesn't you feel entitled to hurl abuse at the maintainers. Just stop.

@baack
Copy link

@baack baack commented Jul 16, 2021

Once again somebody replies with off-topic (not related to the actual bug discussed).

That goes two ways.

Yes it does. And look, I'm not telling anybody "it's F/LOSS, so shut up", am I? Use your right to speak as you wish.

Apply this thinking to your comments

Sorry, I can't. I see no logic of your proposal, really. Because my comment was good - detailed, convincing and right. And was not made in 5 years.

So it's not that the desktop version is bad, or missing features from the mobile app. No version has this ability. Its not that expectations from mobile are met with surprise on desktop.

Not true:

  1. the mobile version is half-working - it's possible to rename contacts and remove via Android contacts. Ugly and not flexible, but possible.
  2. the mobile version does not show some dead contacts from long past, nor it shows contacts that were never added (of some people who added me to contacts). Check yourself the difference next time before jumping to conclusions.

Have you even read the posts in this issue? People told all that's needed.
And the first post from 2017 has 23 likes, while there were no likes on github in 2017 (4 years ago!), so all this likes are from people who came after 2017.

You can simulate that reality with incredible precision by not using signal desktop.

Thanks for this piece of advice, but it's not true. The existence of one bad official Signal desktop application reduces chances of getting another one (good or any at all) by many-many times. The reality is different, see. Read my message again if you did not get this part.

Do you also have a romantic partner from another high school?

Hmm, what are you talking about, pal, are you OK?

@kyeotic
Copy link

@kyeotic kyeotic commented Jul 16, 2021

Once again somebody replies with off-topic (not related to the actual bug discussed).

Just to be clear, your position is that if I respond to you and your behavior in this thread that's off-topic because you are not the bug? That's a nice way to make yourself immune to criticism. It's also hypocritical, since you have no issue with replying to others with your comically self-righteous justifications (e.g. my comment was good - detailed, convincing and right) for your complaints that this project has taken so long to remedy your suffering.

Have you even read the posts in this issue? People told all that's needed.

Indeed they have. You adding comments like Isn't it ridiculous? and repeatedly saying that this is a bad application add nothing of value to the discussion. The issue has been stated, the community has shown support with emoji-reactions. You complaining and bashing the product and its developers is toxic and unnecessary. Please stop.

@baack
Copy link

@baack baack commented Jul 17, 2021

Too much about me, too little about basic bugs not being fixed in many years. In the main desktop version of application.

The issue has been stated, the community has shown support with emoji-reactions.

Let's hope emoji-reactions will make it possible for signal-desktop to rename or remove contacts in next 5-10 years, that'll be great! Or maybe after 5 years the clicking on tray icon (flatpak version has no icon at all, btw) will make it possible to open application at once! That will be great too.

Maybe it's just not enough emojis were provided in last five years by community?
Yeah, that's the problem, I see it now, not bad development, but lack of emojis, sorry that I was wrong.

@datamafia
Copy link

@datamafia datamafia commented Jul 20, 2021

Let's settle this - can you confirm that no external party or government is pressuring for the retention of this tracking paradigm? Considering the nature of the project, people engaged, and the ecosystem, there is clearly a blocker that Signal can't talk about. Joe Rogan ragged on Marley on JRE about this item with a very odd answer. I smell funny business, so I am offering this canary.

@julianfairfax
Copy link

@julianfairfax julianfairfax commented Sep 11, 2021

I wrote a forum post that addresses this issue. If you're a user with feedback or experiences to share, or a developer who can actually take a look at implementing this, please check out the post: https://community.signalusers.org/t/handle-contacts-properly/36807

@andrewbanchich
Copy link
Author

@andrewbanchich andrewbanchich commented Sep 29, 2021

@josh-signal I consider this a bug, not a feature request.

@josh-signal
Copy link
Collaborator

@josh-signal josh-signal commented Sep 29, 2021

I agree that it is very frustrating that an expected feature is missing, specially this one. Nonetheless this is would be a new feature and it would help us prioritize these if there is discussion in the community forums regarding it.

@baack
Copy link

@baack baack commented Sep 30, 2021

@josh-signal
Nicely done! Let's wait for another 5-10 years for messenger to get an ability to remove contact. Because we can.

@lschwetlick

I agree that this is an important issue to fix, but ...

See, it was not an important issue to fix, not even an issue after all, but feature request! :)

@kyeotic
Sorry that we failed to provide enough emodjies to make this bug get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Next steps
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet