-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing reactions #4336
Comments
Do more debug logs (and message IDs) help to track this down or did you already understand why this is happening? |
Looks like 4289c28 improved the behaviour a lot!!! In my testing and trying to break things ;) around 7 emoji reactions did not make it through, but the rest now made it through :) Not sure how many reactions I sent, probably 60 - 100 all in all. 3 of the not received ones:
Desktop log (like Desktop 1 above; now on SignalBeta/1.34.4-beta.1): Android log: EDIT: I did go through my groups, where reactions were also sent after I upgraded to the newest desktop beta - and there I can find also a few reactions missing on desktop. Mainly from other people. They are received on my phone, but did not survive to the desktop app. Do more examples with message IDs help? I could try to get some more logs... Just tell me. |
It seems I’m having this issue as well, but my Signal Desktop device was not offline for more than a day. https://debuglogs.org/e2fafaf0c05ce05a41e4df2f8cd4c90831d88827860c978db786a30b0dd092f0 If you don’t mind a suggestion @ainerzufall, I would retitle the issue to Sent reactions missing from group conversations. I was writing what would have been a duplicate issue before I realized what “any emoji reactions” meant. Huge thanks in advance to the devs, when y’all can get to this. |
@shortenjukebox I can definitely remove the "any emoji" part. Other than that I also experienced it in 1on1 conversations as well as on received emoji reactions, so your suggested title would narrow it down too much. |
Ah strange, the issue doesn’t occur in my single-recipient conversations (as far as I can tell)
From: rainerzufall <notifications@github.com>
To: signalapp/Signal-Desktop <Signal-Desktop@noreply.github.com>
CC: shortenjukebox <h0w2b+github20180523001@posteo.org>, Mention <mention@noreply.github.com>
Received: Sep 27, 2020 04:03:31
…Subject: Re: [signalapp/Signal-Desktop] Missing reactions (possibly related to the new "any emoji reactions") (#4336)
@shortenjukebox[https://github.com/shortenjukebox] I can definitely remove the "any emoji" part. Other than that I also experienced it in 1on1 conversations as well as on received emoji reactions, so your suggested title would narrow it down too much.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub[#4336 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABB4LRRF45EIGXJ6OBLG3NLSH3WVFANCNFSM4NYRPYTA]. [https://github.com/notifications/beacon/ABB4LRW7R33COPO4DUHSPH3SH3WVFA5CNFSM4NYRPYTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFGZRCYY.gif]
|
For the past two weeks I’ve noticed that some reactions and some messages don’t sync between phone and desktop, which sounds like the same issue. In my case though, both phone and desktop are connected all the time. The desktop may have periods of being switched off, but these are few and far between. The logs below concern a reaction from desktop that did not sync to phone, this happened 35min before the logs were taken. Both devices had full connectivity at the time. Debug log from phone: Debug log from desktop: |
I didn't see any missing reactions but any picture sent without caption in GV2 group from Desktop app isn't visible on my phone. Pictures with captions are visible. This issue doesn't occur when I send from my phone or from desktop in legacy groups and 1:1 chats. Edit: OK, I've just seen that some my reactions from Desktop are missing in Android. Debug log from Desktop Debug log from phone |
Thanks. No updates, but these debug logs are helpful. |
More testing reveals that NO reactions done in a v2 group on my ipad sync to my phone. Reactions done on the ipad in a v1 group always sync to my phone. Ipad v3.18.0.5 Debug log from ipad: Debug log from phone: |
I have the same issue. My own reactions which I posted from my desktop client are not appearing on my android client Debug log - Signal Desktop v1.36.3-beta.2 on Ubuntu 20.04 Debug log - Signal Android 4.72.2 on Lineage OS (Android 9) |
signalapp/Signal-Android@caf8bb3 fixed the issue with reactions not being sent from Desktop to my own devices! 🥳 But even after updating there are still occasions of missing reactions. Received on mobile, but not on Desktop, for example:
|
Hi, I had this issue again with up-to-date stable versions.
I sent the message from Desktop-1 to a group, it got 5 reactions. But I have a linked Desktop-2 (Win10) as well, what was offline for 2 days. I don't think message limit (1000) was reached, there were no big traffic during this 2 days. Message Missing reaction's sender-1: xxx873 (Android) Desktop-1 (message sender) log: Desktop-2 log: iPhone log: |
I still have regulary problems (only on desktop clients) with missing reaction emojis. Last time I received 2 messages in a group (from the same person) and I put 1-1 reaction emojis on them - from my primary (mobile) device (iPhone). Later I opened my laptop, Signal Desktop synced all messages, but my reactions were not there. Message-1: 1603705748377 (sent timestamp)
Message-2: 1603705776497 (sent timestamp)
My primary device: iOS 14.1, Signal v3.21.0.10 My Desktop-1: Signal v1.37.2 (Mac OSX) My Desktop-2 (Win10) is offline for 5 days now. Friend has an Android primary device and a Linux desktop client. He sent the 2 messages from his desktop clent. The messages arrived in order on all my devices - the problem is only with reaction emojis. Friend linux desktop (v1.37.2) debug log: One additional detail that might doesn't matter: my friend replaced today his phone and reinstalled Signal on that (Android) - security number changed. But all his messages above came after this act. The group is a v1 (legacy) type group. |
We have a fix for missing reactions coming out in our next release - please try things out on our next build! |
Hi @scottnonnenberg-signal |
Glad to hear! I'll let @rainerzufall close this issue. :0) |
@scottnonnenberg-signal Thanks for the honors, I would be happy to and I hate to say this, but it looks like the issue is not solved yet. :( message ID: 1604597260402 message ID:
log: https://debuglogs.org/fd83a866c2b4342a635ff0813d59f56608a1ce29d6377794989b4ca19f746bd3 additional info:
I could give you more message IDs we can see several other messages with missing reactions. Please let me know what info would help you. |
Could it be different if it's a GV1 or GV2 group..? |
Still experiencing that issue on Signal Desktop for Linux On my Desktop App no Reactions were displayed. Maybe it happens, because the reactions were send before my Desktop App received the message for the first time. (The Desktop App was not online when the message and reactions were send). Desktop:
Android:
Desktop Log: https://debuglogs.org/8b23427111cc2e0e81fc8fdbd1d6114fb6e812ca070b585243a0d8dd74800da6 Desktop Version v5.3.0 |
@tintinmaster Thanks for the bug report. Is this consistent behavior for you, or does it only happen sometimes? |
@scottnonnenberg-signal It happened only once. But I can add to my report, that the message with missing reactions was a reply to another message. I tested it today with a reply and a normal message, but it worked flawless |
@scottnonnenberg it also still happens for me from time to time, I just never reported it anymore as I thought it wouldn't add much for you. As it just happened to me again (this time reactions sent from my phone where not received on my desktop app) I throw in some new logs :) Hopefully something actionable is in there:
ID of message 1: 1622637246226 Android log:
IDs of message 1: IDs of message 3: Desktop log: |
re: #3451 aaand about 1.5 years later, it's gone - who in their right mind could possibly think that something that was 2 clicks previously should be fricking 30 now 🤦🏻♂️ the recent updates have made Signal completely unusable - need to react to 4 messages quickly to acknowledge them? previously:
after recent batch of regressions in user experience and app capabilities:
this is awful, and I cannot use Signal anymore |
@quinndiggity Have you tried widening the window, so you get the dedicated reaction button back? |
Bug Description
Screenshots
one of the missing reactions (there are four more reactions missing in total; I can provide their IDs if helpful)
Android message ID: 1591531679868 (message was not sent by me; unfortunately can't find it in the Android log, hopefully the report is still helpful )
received reaction
Android message ID: 1591543638639 (same as above applies to this ID)
Platform Info
Signal Version:
Desktop 1:
SignalBeta/1.34.0-beta.3
Desktop 2:
Signal/1.34.1
Operating System:
Desktop 1:
Windows 10* 64-bit
Desktop 2:
Windows 7* 64-bit
Linked Device Version:
Link to Debug Log
Desktop 1:
https://debuglogs.org/d477bca8ab8a57ff236e7c0617a58075fa2b5a666d12787f162cafef2ff99cf7
Desktop 2:
https://debuglogs.org/8a7f90f4bd7f4f04ed3265509605b60270f46269412065d9b3f441fd7a90cca4
Android:
https://debuglogs.org/114a8e8f17e13fa1c99e631b60e72945413e19b92f00889214f20bb2a635faf4
The text was updated successfully, but these errors were encountered: