Profiles #1453

liliakai · 2017-09-08T14:07:45Z

Adds support for downloading, decrypting, and displaying profile names and avatars, syncing profile keys from the master device, sending and receiving profile keys, and inferring profile whitelisting.

With tests.

// FREEBIE

When AES-GCM authentication fails, webcrypto returns a very generic error. The same error is thrown for invalid length inputs, but our earlier checks in decryptProfile should rule out those failure modes and leave us safe to assume that we either had bad ciphertext or the wrong key. // FREEBIE

// FREEBIE

Use different ones for staging and production // FREEBIE

// FREEBIE

Synced contact avatars will still override profile avatars.

Only if we don't have a synced contact name. // FREEBIE

// FREEBIE

For standalone accounts, generate a random profile key. // FREEBIE

Android will use a contact sync message to sync a profile key from Android clients who have just upgraded and generated their profile key. Normally we should receive this data in a provisioning message. // FREEBIE

Requires that `profileSharing` be set on the conversation. // FREEBIE

When receiving a message with this flag, don't init a message record, just process the profile key and move on. // FREEBIE

scottnonnenberg

Pretty exciting stuff! Really cool to see profiles show up in the app. :0)

There are a couple changes still necessary to fine-tune the experience: managing the cache, pulling down new profiles when we see them, and error handling.

scottnonnenberg · 2017-09-08T16:32:10Z

js/background.js

+            console.log('Got sync message with our own profile key');
+            storage.put('profileKey', profileKey);
+          }
+          return ev.confirm();


I think we should eliminate the return here, since it will prevent the creation of a local Conversation for yourself. And I'm pretty sure we rely on it for conversations with yourself, and display of the members in a group.

scottnonnenberg · 2017-09-08T16:34:17Z

js/background.js

+        if (data.message.flags & textsecure.protobuf.DataMessage.Flags.PROFILE_KEY_UPDATE) {
+            var profileKey = data.message.profileKey.toArrayBuffer();
+            return ConversationController.getOrCreateAndWait(data.source, 'private').then(function(sender) {
+              return sender.setProfileKey(profileKey).then(ev.confirm);


Calling ev.confirm() at the end of this save is probably too aggressive. I think we want to wait until all message processing is complete.

I think we should avoid initializing a Whisper.Message that we don't want to save. Neither ios or android are saving message records for profile key updates.

Also, handleDataMessage will have side effects like bumping the conversation to the top of the list, triggering a notification, etc... which would be weird when no new message bubble is being added.

Ah, again I'm mistaken about how flags are used. The design of the data structure suggests that any message can have multiple flags, and be a normal message as well. But you're telling me that a DataMessage is one of: 1) a normal message 2) a empty message with any single flag

scottnonnenberg · 2017-09-08T16:34:36Z

js/background.js

+        if (data.message.flags & textsecure.protobuf.DataMessage.Flags.PROFILE_KEY_UPDATE) {
+            var id = data.message.group ? data.message.group.id : data.destination;
+            return ConversationController.getOrCreateAndWait(id, 'private').then(function(convo) {
+              return convo.save({profileSharing: true}).then(ev.confirm);


Same here. Wait until the confirm() call at the end of handleDataMessage()

scottnonnenberg · 2017-09-08T16:36:48Z

js/models/conversations.js

+                c.setProfileAvatar(profile.avatar)
+              ]).then(function() {
+                // success
+                c.save();


Probably makes sense to surround this with a new Promise() to capture any errors generated.

scottnonnenberg · 2017-09-08T16:44:08Z

libtextsecure/message_receiver.js

@@ -765,6 +765,9 @@ MessageReceiver.prototype.extend({
        } else if (decrypted.flags & textsecure.protobuf.DataMessage.Flags.EXPIRATION_TIMER_UPDATE ) {
            decrypted.body = null;
            decrypted.attachments = [];
+        } else if (decrypted.flags & textsecure.protobuf.DataMessage.Flags.PROFILE_KEY_UPDATE) {


I'm surprised that our flags handling uses else if given that our flags bitpacking technique can result in multiple flags. Are we really sure that we'll only get one of these at a time?

In practice this has always been the case, yes.

scottnonnenberg · 2017-09-08T16:45:15Z

libtextsecure/test/crypto_test.js

@@ -0,0 +1,54 @@
+describe('encrypting and decrypting profile data', function() {


Could we perhaps name this file profile_crypto_test.js if it's specific to profiles?

scottnonnenberg · 2017-09-08T16:56:16Z

js/models/conversations.js

@@ -72,6 +72,7 @@
        this.messageCollection.on('send-error', this.onMessageError, this);

        this.on('change:avatar', this.updateAvatarUrl);
+        this.on('change:profileAvatar', this.updateAvatarUrl);


I think we need a change:profileKey handler here which will go fetch the user's profile, thereby pulling new profile information. I just tried sharing my profile key via a message, and because the recipient already had the conversation open, nothing changed. Left the conversation and came back, still no change, because we throttle profile get. Had to restart to see the profile avatar.

When clicking on a notification in Windows when a window had been stuck to one side of the screen using Snap, the window would be repositioned. Fixes #1453 FREEBIE

// FREEBIE

Don't return early if we get a contact sync for our own number // FREEBIE

scottnonnenberg

Looking good!

When clicking on a notification in Windows when a window had been stuck to one side of the screen using Snap, the window would be repositioned. Fixes #1453 FREEBIE

Contact profiles support - display avatars and names (#1453) Audio notes can now be recorded on Windows (#1456) When window is snap-positioned on windows, no longer automatically re-position window (#1455) Ensure that our sound setting applies for all notification types (#1445) Fix loading screen hang with application is unlinked (#1440) Fix error dialog on initial load (#1440) Based on https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v0.43.3 FREEBIE

When clicking on a notification in Windows when a window had been stuck to one side of the screen using Snap, the window would be repositioned. Fixes #1453 FREEBIE

* Add AES-GCM encryption for profiles With tests. * Add profileKey to DataMessage protobuf // FREEBIE * Decrypt and save profile names // FREEBIE * Save incoming profile keys * Move pad/unpad to crypto module // FREEBIE * Support fetching avatars from the cdn // FREEBIE * Translate failed authentication errors When AES-GCM authentication fails, webcrypto returns a very generic error. The same error is thrown for invalid length inputs, but our earlier checks in decryptProfile should rule out those failure modes and leave us safe to assume that we either had bad ciphertext or the wrong key. // FREEBIE * Handle profile avatars (wip) and log decrypt errors // FREEBIE * Display profile avatars Synced contact avatars will still override profile avatars. * Display profile names in convo list Only if we don't have a synced contact name. // FREEBIE * Make cdn url an environment config Use different ones for staging and production // FREEBIE * Display profile name in conversation header * Display profile name in group messages * Update conversation header if profile avatar changes // FREEBIE * Style profile names small with ~ * Save profileKeys from contact sync messages // FREEBIE * Save profile keys from provisioning messages For standalone accounts, generate a random profile key. // FREEBIE * Special case for one-time sync of our profile key Android will use a contact sync message to sync a profile key from Android clients who have just upgraded and generated their profile key. Normally we should receive this data in a provisioning message. // FREEBIE * Infer profile sharing from synced data messages * Populate profile keys on outgoing messages Requires that `profileSharing` be set on the conversation. // FREEBIE * Support for the profile key update flag When receiving a message with this flag, don't init a message record, just process the profile key and move on. // FREEBIE * Display profile names in group member list * Refresh contact's profile on profile key changes // FREEBIE * Catch errors on profile save // FREEBIE * Save our own synced contact info Don't return early if we get a contact sync for our own number // FREEBIE

Contact profiles support - display avatars and names (#1453) Audio notes can now be recorded on Windows (#1456) When window is snap-positioned on windows, no longer automatically re-position window (#1455) Ensure that our sound setting applies for all notification types (#1445) Fix loading screen hang with application is unlinked (#1440) Fix error dialog on initial load (#1440) Based on https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v0.43.3 FREEBIE

liliakai added 12 commits September 8, 2017 15:57

Add AES-GCM encryption for profiles

7efbd01

With tests.

Add profileKey to DataMessage protobuf

a1c9d15

// FREEBIE

Save incoming profile keys

849253e

Decrypt and save profile names

94434d5

// FREEBIE

Move pad/unpad to crypto module

61b4194

// FREEBIE

Support fetching avatars from the cdn

97a0e55

// FREEBIE

Make cdn url an environment config

5d3c742

Use different ones for staging and production // FREEBIE

Handle profile avatars (wip) and log decrypt errors

57b1bb2

// FREEBIE

Display profile avatars

8a80422

Synced contact avatars will still override profile avatars.

Display profile names in convo list

a9eb57d

Only if we don't have a synced contact name. // FREEBIE

Display profile name in conversation header

99a461c

liliakai force-pushed the profiles-electron branch 2 times, most recently from 68c7b85 to 46eb012 Compare September 8, 2017 14:30

liliakai added 3 commits September 8, 2017 17:11

Display profile name in group messages

3f1f8ba

Update conversation header if profile avatar changes

061abef

// FREEBIE

Style profile names small with ~

830e1a2

liliakai force-pushed the profiles-electron branch from 46eb012 to 7587be0 Compare September 8, 2017 15:13

liliakai added 7 commits September 8, 2017 18:52

Save profileKeys from contact sync messages

1039927

// FREEBIE

Save profile keys from provisioning messages

2a75aa9

For standalone accounts, generate a random profile key. // FREEBIE

Special case for one-time sync of our profile key

770c927

Android will use a contact sync message to sync a profile key from Android clients who have just upgraded and generated their profile key. Normally we should receive this data in a provisioning message. // FREEBIE

Infer profile sharing from synced data messages

66d36ef

Populate profile keys on outgoing messages

ef1ae04

Requires that `profileSharing` be set on the conversation. // FREEBIE

Support for the profile key update flag

10729d6

When receiving a message with this flag, don't init a message record, just process the profile key and move on. // FREEBIE

Display profile names in group member list

593eac8

liliakai force-pushed the profiles-electron branch from 7587be0 to 593eac8 Compare September 8, 2017 16:52

scottnonnenberg reviewed Sep 8, 2017

View reviewed changes

scottnonnenberg mentioned this pull request Sep 8, 2017

focus() visible window on show-window instead of show() #1455

Merged

Refresh contact's profile on profile key changes

bb7906a

// FREEBIE

liliakai added 2 commits September 11, 2017 15:38

Catch errors on profile save

a3bf078

// FREEBIE

Save our own synced contact info

e8e1f3b

Don't return early if we get a contact sync for our own number // FREEBIE

scottnonnenberg approved these changes Sep 11, 2017

View reviewed changes

scottnonnenberg merged commit 33fa666 into electron Sep 11, 2017

scottnonnenberg deleted the profiles-electron branch September 11, 2017 16:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profiles #1453

Profiles #1453

liliakai commented Sep 8, 2017

scottnonnenberg left a comment •

edited

scottnonnenberg Sep 8, 2017

liliakai Sep 11, 2017

scottnonnenberg Sep 8, 2017

liliakai Sep 10, 2017

liliakai Sep 11, 2017

scottnonnenberg Sep 11, 2017

scottnonnenberg Sep 8, 2017

scottnonnenberg Sep 8, 2017

liliakai Sep 11, 2017

scottnonnenberg Sep 8, 2017

liliakai Sep 10, 2017

scottnonnenberg Sep 8, 2017

scottnonnenberg Sep 8, 2017

liliakai Sep 11, 2017

scottnonnenberg left a comment

		@@ -0,0 +1,54 @@
		describe('encrypting and decrypting profile data', function() {

Profiles #1453

Profiles #1453

Conversation

liliakai commented Sep 8, 2017

scottnonnenberg left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

scottnonnenberg left a comment

Choose a reason for hiding this comment

scottnonnenberg left a comment •

edited