New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .deb specific dependencies #1858
Merged
scottnonnenberg
merged 1 commit into
signalapp:development
from
veggiedefender:deb-dependencies
Dec 14, 2017
Merged
Add .deb specific dependencies #1858
scottnonnenberg
merged 1 commit into
signalapp:development
from
veggiedefender:deb-dependencies
Dec 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some barebones debian-based systems (e.g. Docker containers) don't come with the libasound2 and libxss1 libraries, which electron-builder does not include by default.
Sorry, cannot test this atm, but here is my Dockerfile:
And the run command:
|
Working great! |
scottnonnenberg
added a commit
that referenced
this pull request
Dec 15, 2017
Fix issue where .tif file attachments could not be sent or received (#1901) Support the latest phone number formats via libphonenumber update (#1899) Intl-friendly sort order for contact lists (#1900) Show window if hidden to tray when second instance attempts to start (#1897) Make the window minimum width a little smaller - thanks @emptyflask (#1863) Fix issue where duplicate emoji were listed in the emoji panel (#1893) The default button is now 'later', not 'restart' in the 'update available' dialog (#1894) Dev: - Add .deb specific dependencies - thanks @veggiedefender (#1858)
scottnonnenberg
added a commit
that referenced
this pull request
Dec 20, 2017
Note: This release is the same thing as https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.1.0-beta.6 Listed below are the changes from the previous production release: https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.0.41 Update to electron 1.7.9 (#1736) Support the latest phone number formats via libphonenumber update (#1899) Reduce download size by ~25MB over the previous production build (#1869) Emoji - thanks @liliakai: - Emoji picker (#1608) - Add support for Emoji 5 (#1797) Notifications: - Windows 7: Use an alternate mechanism for notifications (#1812) - Prevent drawAttention() when notifications are turned off - thanks @canerelci! (#1612) Linux: - Support for current (artful) and previous (xenial) ubuntu versions (#1856) - Fix missing application icon on some Linux distributions (#1735) - Fix issue where window would not show new message alerts on some Linux systems - thanks @cornerman (#1820) - Add .deb specific dependencies - thanks @veggiedefender (#1858) The default button is now 'later', not 'restart' in the 'update available' dialog (#1894) Make the window minimum width a little smaller - thanks @emptyflask (#1863) Intl-friendly sort order for contact lists (#1900) Fix issue where update would restore deleted windows shortcut (#1804) Fix issue where .tif file attachments could not be sent or received (#1901) (in testing) Add a tray icon to the application behind command-line argument - thanks @m-pilia (#1676) --use-tray-icon enables the tray icon --start-in-tray enables the tray icon and the application starts minimized in the tray bar (in testing) Support pass-through proxies with HTTPS_PROXY environment variable (#1878) Dev: - Display of environment and app instance in title bar/about window (#1606) - Support for beta releases installed beside production versions (#1606) - Fix json parsing exceptions obscuring server errors (#1605) - Be resilient to thrown non-errors in import process (#1737)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
Adds
libasound2
andlibxss1
to the generated.deb
's dependencies, as well as the default.deb
dependencies included byelectron-builder
(["gconf2", "gconf-service", "libnotify4", "libappindicator1", "libxtst6", "libnss3"]
).Probably fixes #1838, but @angelo-v should probably test this out first, since I can't get my docker setup to open windows on my host OS.