Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document building/testing releases #1867

Merged
merged 2 commits into from
Jan 8, 2018
Merged

Document building/testing releases #1867

merged 2 commits into from
Jan 8, 2018

Conversation

veggiedefender
Copy link
Contributor

Contributor checklist

  • My contribution is fully baked and ready to be merged as is
  • My changes are rebased on the latest master branch
  • My commits are in nice logical chunks
  • I have followed the best practices in my commit messages
  • I have tested my contribution on these platforms:
  • This is a change in documentation
  • My changes pass all the local tests 100%
  • I have considered whether my changes need additional tests, and in the case they do, I have written them

Description

See #1835. Testing out the build system is currently undocumented, but this PR adds some instructions to CONTRIBUTING.md for building/testing new releases.

@scottnonnenberg
Copy link
Contributor

Let's put this lower in the file, say right after the Dependencies section at the bottom.

@veggiedefender
Copy link
Contributor Author

Got it!

@scottnonnenberg scottnonnenberg merged commit 205d11d into signalapp:master Jan 8, 2018
@veggiedefender veggiedefender deleted the patch-1 branch January 8, 2018 21:56
scottnonnenberg pushed a commit that referenced this pull request Jan 8, 2018
* Document building/testing releases

* move instructions for testing releases to bottom
scottnonnenberg added a commit that referenced this pull request Jan 11, 2018
Update to Electron 1.7.10 (#1919)

Fix issue where clicking Windows notification breaks window out of
aero-snap location (#1918)

Fix issue where old log data would persist in logs dir (#1945)

Fix issue where disabled send field (in the middle of send) could be
edited after click (#1937)

Update strings (#1921)

Dev:
  - Fix error to console when verifying contact in standalone mode
    (#1961)
  - Remove all built assets from repo (#1955)
  - Log out information from DOMException when import fails (#1923)
  - Log clearer messages regarding prekey/signed prekey fetches (#1961)
  - Make errors more debuggable; capture correct stack, include name
    (#1944)
  - Add eslint/mocha with code coverage for non-browser code (#1945)
  - Revamped github issue and pull request templates, updates to
    contributing.md/readme.md (#1955 and #1956)
  - Document building/testing releases in Contributing.md,
    thanks @veggiedefender (#1867)
  - Update a number of dependencies to the latest: builder, websocket,
    spellcheck (#1920)
scottnonnenberg added a commit that referenced this pull request Jan 23, 2018
_Note: This release is equivalent to [v1.2.0-beta.2](https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.2.0-beta.2). Listed below are the changes from the previous production release: [v1.1.0](https://github.com/WhisperSystems/Signal-Desktop/releases/tag/v1.1.0)_

Update to Electron 1.7.10 (#1919)

Fixed: clicking Windows notification would break window out of aero-snap location (#1918)

Fixed: forwarded video would not play (#1977)

Fixed: conversation was inaccessible if group member had invalid phone number (#1968)

Fixed: powershell warning caused cert validation of downloaded update to fail on windows (#1976)

Fixed: 'Missing signed prekey' errors after re-link (#1979)

Fixed: data older than three days would persist in logs dir (#1945)

Fixed: in the middle of send, disabled send field could be edited after click (#1937)

Update strings (#1921)

Add badge with unread count to the tray icon - thanks @m-pilia (#1934)
_Note:_ to try this test feature out, use the `--use-tray-icon` and `--start-in-tray` command-line arguments

Dev:
  - Additional logging for unexpected situations during sort of conversation list (#1969)
  - Dependency updates, fixes required for successful release (#1966 and #1976)
  - Log more info along with http errors (#1968)
  - Fix error to console when verifying contact in standalone mode (#1961)
  - Remove all built assets from repo (#1955)
  - Log out information from DOMException when import fails (#1923)
  - Log clearer messages regarding prekey/signed prekey fetches (#1961)
  - Make errors more debuggable; capture correct stack, include name (#1944)
  - Add eslint/mocha with code coverage for non-browser code (#1945)
  - Revamped github issue and pull request templates, updates to contributing.md/readme.md (#1955 and #1956)
  - Document building/testing releases in Contributing.md, thanks @veggiedefender (#1867)
  - Update a number of dependencies to the latest: builder, websocket, spellcheck (#1920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants