Show View -> Debug on OSX, ensure Debug Log is visible #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasi
approved these changes
Mar 1, 2018
| // eslint-disable-next-line no-param-reassign | ||
| template[3].submenu = [ | ||
| template[windowIndex].submenu = [ |
There was a problem hiding this comment.
Nice! 😄
Lines 279 to 281 in a3cf81b
There was a problem hiding this comment.
Yep, this is a reimplementation, but it's ready for hotfix. :0)
scottnonnenberg
added a commit
that referenced
this pull request
Mar 1, 2018
scottnonnenberg
added a commit
that referenced
this pull request
Mar 1, 2018
Note: This release is equivalent to v1.5.2 Fixed: If interrupted in the middle of an import, next registration would leave that imported data in the database (#2072) Fixed: In some cases on OSX, View menu would not have Debug Log option (#2089) Fixed: In import/registration flow, choosing View -> Debug Log would do nothing (#2089) Fixed: In some cases contact/group syncs would turn off disappearing messages in all conversations (#2086) Fixed: On initial setup, conversations with disappearing messages enabled would be at the top of the conversation list (#2084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to the import/registration workflow screens.