Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Theme: Ensure conversation panel fills screen vertically #2144

Merged
merged 1 commit into from Mar 19, 2018
Merged

iOS Theme: Ensure conversation panel fills screen vertically #2144

merged 1 commit into from Mar 19, 2018

Conversation

gasi-signal
Copy link
Contributor

Fixes small regression from ef041b2

Before

signal_beta

After

signal_-_development

/ht @michaelkirk

scottnonnenberg
scottnonnenberg approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@scottnonnenberg scottnonnenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I really like that it is targeted.

Something to think about: why did this stop working all of a sudden? I didn't touch that calc() statement in my recent CSS changes. Makes me think that now the conversation panel extends under the header at the top, where it didn't before. Might that have some unexpected effects? I know we calculate visibility for marking messages read, but that area at the top is unlikely to make a difference - the bottom of the window is more important...

@rainerzufall rainerzufall mentioned this pull request Mar 19, 2018
Closed
1 task
@gasi-signal
Copy link
Contributor Author

Something to think about: why did this stop working all of a sudden? I didn't touch that calc() statement in my recent CSS changes. Makes me think that now the conversation panel extends under the header at the top, where it didn't before.

Yes, your change took the header out of the document flow due to position: absolute: ef041b2#diff-103df050a87bae776240ba9f9ec90647R67 Good point about unread messages computation. Another option would be to make the window position: absolute as well and pin it right below the header. Or potentially introduce a margin-top with the same height as the header. But that would require more testing and we have higher priorities at this point.

@scottnonnenberg-signal
Copy link
Contributor

Cool. Think we're good to go. :0)

@gasi-signal
Ensure conversation panel fills screen vertically
685f05a 
Required addition to the following change:
ef041b2
@gasi-signal gasi-signal force-pushed the ios-theme-conversation-panel-height branch from 36524e2 to 685f05a Compare March 19, 2018 22:10
@gasi-signal
Copy link
Contributor Author

Rebased against latest development branch before merge without changes.

@gasi-signal gasi-signal merged commit 37d35db into development Mar 19, 2018
@gasi-signal gasi-signal deleted the ios-theme-conversation-panel-height branch March 19, 2018 23:20
@gasi-signal gasi-signal mentioned this pull request Mar 20, 2018
Merged
scottnonnenberg-signal added a commit that referenced this pull request Mar 20, 2018
@scottnonnenberg-signal
1.7.0-beta.2
0d105fc 
Fixed: White block at bottom of conversation panel in iOS theme
(#2144 and #2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(1c6d91b)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (#2128)
  - Preparation for encrypted backups
    (cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (6d8f4b7)
gasi pushed a commit to gasi/Signal-Desktop that referenced this pull request Mar 22, 2018
@scottnonnenberg-signal @gasi
1.7.0-beta.2
04b9054 
Fixed: White block at bottom of conversation panel in iOS theme
(signalapp#2144 and signalapp#2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(signalapp@1c6d91b)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (signalapp#2128)
  - Preparation for encrypted backups
    (signalapp@cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (signalapp@6d8f4b7)
Vinnl pushed a commit to Vinnl/Signal-Desktop that referenced this pull request Mar 23, 2018
@scottnonnenberg-signal @Vinnl
1.7.0-beta.2
19a64b3 
Fixed: White block at bottom of conversation panel in iOS theme
(signalapp#2144 and signalapp#2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(signalapp@1c6d91b)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (signalapp#2128)
  - Preparation for encrypted backups
    (signalapp@cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (signalapp@6d8f4b7)
Vinnl pushed a commit to Vinnl/Signal-Desktop that referenced this pull request Mar 23, 2018
@scottnonnenberg-signal @Vinnl
1.7.0-beta.2
439fc39 
Fixed: White block at bottom of conversation panel in iOS theme
(signalapp#2144 and signalapp#2153)

Fixed: Would attempt to rotate signed prekey every five seconds,
forever, after app discovers it is unlinked
(signalapp@1c6d91b)

Dev:
  - Introduce IndexedDB index on `messages` store tracking
    `schemaVersion` (signalapp#2128)
  - Preparation for encrypted backups
    (signalapp@cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of
    attachments (signalapp@6d8f4b7)
scottnonnenberg-signal added a commit that referenced this pull request Apr 11, 2018
@scottnonnenberg-signal
v1.7.0
699acc6 
Note: this release is equivalent to v1.7.0-beta.3. The changes listed below are compared to the previous production release, v1.6.1.

Update to electron 1.8.4 (#2186)

Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)
Save attachments to disk when importing Chrome app export (#2212)

New option in settings: delete all application data (383e02e, #2144 and #2153)

Remove all configuration in database when we discover we are unlinked (9acb189 and 1c6d91b)

Delete everything in database when we link with a different phone number from previous link (9acb189)

Windows: Delete all data on uninstall (c855597)

Fixed: Read receipts setting would not be synchronized along with re-link (#2218)

Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (#2032)

Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)

Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)

Dev:
  - Redact file paths in anything that goes to the log on disk (#2110)
  - When top-level process errors happen, don't show dialog with stack trace (#2110)
  - Add `nsp` to CI runs (fd056e1)
  - Add eslint-plugin-mocha to disallow exclusive tests using *.only (#2110)
  - Preparation for encrypted backups (cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of attachments (6d8f4b7)
  - Relax Node.js version requirements (#2203)
  - Fix a few typos in documentation - thanks @Vinnl (#2171)
  - Update issue template to mention that translation should be via Transifex (#2157)
@sudoWright sudoWright mentioned this pull request Mar 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottnonnenberg scottnonnenberg scottnonnenberg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gasi-signal @scottnonnenberg-signal @scottnonnenberg