Don't close emoji picker when Ctrl key is pressed (resolves #5062) #5431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn-Signal
approved these changes
Aug 2, 2021
rik-smeets
force-pushed
the
fix-bug-5062
branch
from
e9a18fa
to
0701ca9
Compare
|
@EvanHahn-Signal |
|
I expect this to be released in 5.13 or later. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
When the emoji picker was opened, pressing the Ctrl-key would close it. Because of that, the zoom in/out accessibility features couldn't be used at that time. With this commit, the Ctrl-key will no longer trigger the closing of the emoji picker.
Tested on Windows 10* 64-bit, manually by using the emoji picker both before and after the changes to test if the change indeed fixes the issue whilst not causing any new issues.
Fixes #5062.