Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sgnl:// URL scheme (Closes #11) #95

Closed
wants to merge 6 commits into from
Closed

Support sgnl:// URL scheme (Closes #11) #95

wants to merge 6 commits into from

Conversation

abcdev
Copy link
Contributor

@abcdev abcdev commented Aug 3, 2014

possible examples (similar to #11 but respecting NSURL query formatting)

  • sgnl://call?+12345689
  • sgnl://call?012346789
  • sgnl://text?+912415123
  • sgnl://vcode?123456

Rainer Killinger added 6 commits August 3, 2014 15:05
make Signal respond to sgnl://
ce5b8f2
changed phoneNumber property to strong, so
a206f93 
“showDialerViewControllerWithNumber:” works in every situation.

added “populateNumberLabelWithNumber:” so number can be set
if controller is already shown
Added support for URLScheme similar to #11.
80c6d5c 
possible hosts: call,text(unsupported),vcode
return NO per default.
respect [Environment isrRegistered] and call state.
Added “popuateChallengeTextFieldInputWithString”
104546d 
sets challengeCode only if registerPhoneNumberTapped was fired successfully.
if it didn’t display UIAlertView with proper warning.
Added logic to handle of all cases number input via query
930a980
Added logic to handle all cases of entering challenge code via query
e863971
@FredericJacobs
Copy link
Contributor

Looking at this now. Still unsure how I want to integrate this functionality. Extensions on iOS 8 will bring some pretty cool features to Signal.
Wondering if we could take advantage of the Share contact functionality there to initiate phone calls and messages.

img_0001

@abcdev
Copy link
Contributor Author

abcdev commented Aug 6, 2014

Good point but there are some downsides with extensions (i.e. contact sharing):

  1. Even though adaptionrate of new iOS versions is quite good. This would cut off all iPhone 4 users and the ones staying on iOS7.
  2. The sharing extension is first and foremost for sharing. This means something like "Call via Signal" or "Text via Signal" in a sharing menu (the button states "Share Contact") is not expected. And I think sending/sharing a contact via Signal will remain unsported for quite a while. (A proper use of this Extension was shown HERE at WWDC2014)
  3. Verification codes arrive via SMS and are an unnecessary input hassle.

@FredericJacobs
Copy link
Contributor

Oh, sorry I wasn't clear. I want to support an URL scheme too. Just wondering how to structure the code base for it.
Reviewing this now

@FredericJacobs FredericJacobs reopened this Aug 6, 2014
@FredericJacobs
Copy link
Contributor

Looks like the type detection of custom URL scheme is not available in Messages.app

@abcdev
Copy link
Contributor Author

abcdev commented Aug 6, 2014

I don't know what causes this. (I have tested this with the Notes.app, iOS8 beta 4&5)
Apple services are, of course, recogniced but also skype://echo123?call is recognized (as soon as skype appstore version is installed).

@FredericJacobs
Copy link
Contributor

Oh, it actually works. For some reason my phone had not correctly recorded the url path.

@fuzzyroddis
Copy link

It would be great if the same protocol was used in RedPhone & TextSecure.

@FredericJacobs
Copy link
Contributor

What do you mean?

@fuzzyroddis
Copy link

@FredericJacobs eg. A link to sgnl://call?+12345689 would open RedPhone Signal on Android too. Will have to wait until the merge of TextSecure and RedPhone.

@mbootsman mbootsman mentioned this pull request Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abcdev @FredericJacobs @fuzzyroddis