This repository has been archived by the owner on Aug 5, 2021. It is now read-only.
always pass the full address to isTrustedIdentity #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with loadIdentityKey and saveIdentity. See also 1fe18c3.
|
What's the OMEMO use case? |
|
To be precise, I think this is important in the OMEMO use case, because an identity key is not shared between devices but every device has his own key. Therefor you can not distinguish between different devices if only the address name (which is the jabber id in my implementation) is passed to |
|
I found a workaround for my setup, but I still think it makes sense to merge the pr for consistency reasons. |
|
Again, what is OMEMO? |
|
@scottnonnenberg OMEMO is an encryption protocol for XMPP which uses the SignalProtocol. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
loadIdentityKeyandsaveIdentity. See also 1fe18c3.This is quite important in the OMEMO use case.