Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ThreadRng? #6

Closed
jack-signal opened this issue Oct 16, 2020 · 0 comments
Closed

Switch to ThreadRng? #6

jack-signal opened this issue Oct 16, 2020 · 0 comments

Comments

@jack-signal
Copy link
Contributor

Since rand 0.7 it has used ChaCha20 which should be ok (older versions used HC-128 which are no bueno due to side channel attacks). ThreadRng should be faster than OsRng on most platforms.

jrose-signal added a commit that referenced this issue Oct 16, 2020
jrose-signal added a commit that referenced this issue Oct 16, 2020
…nableFingerprint

Remove Equatable from ScannableFingerprint
jack-signal added a commit that referenced this issue Oct 19, 2020
@jrose-signal jrose-signal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2022
johanvos pushed a commit to johanvos/libsignal-client that referenced this issue May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants