Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usernames: Enable digest feature on curve25519-dalek dependency #560

Closed

Conversation

kpcyrd
Copy link

@kpcyrd kpcyrd commented Feb 29, 2024

Fixes this compile error:

error[E0599]: no function or associated item named `from_hash` found for struct `Scalar` in the current scope
   --> /home/user/.cargo/git/checkouts/libsignal-e5ca3c64ee2f7cbe/f980fcc/rust/usernames/src/username.rs:218:16
    |
218 |     Ok(Scalar::from_hash(hash))
    |                ^^^^^^^^^ function or associated item not found in `Scalar`
    |
note: if you're trying to build a new `Scalar` consider using one of the following associated functions:
      Scalar::from_bytes_mod_order
      Scalar::from_bytes_mod_order_wide
      Scalar::batch_invert
   --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/curve25519-dalek-4.1.1/src/scalar.rs:239:5
    |
239 |     pub fn from_bytes_mod_order(bytes: [u8; 32]) -> Scalar {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
252 |     pub fn from_bytes_mod_order_wide(input: &[u8; 64]) -> Scalar {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
790 |     pub fn batch_invert(inputs: &mut [Scalar]) -> Scalar {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0599`.
error: could not compile `usernames` (lib) due to 1 previous error

@jrose-signal
Copy link
Contributor

Ha, thanks! We noticed this ourselves a few days ago and patched it, but haven't tagged a new release yet. Sorry for the inconvenience!

@jrose-signal
Copy link
Contributor

jrose-signal commented Feb 29, 2024

I'll leave this open until the release happens, as a reminder. Meanwhile, clients can work around it by explicitly depending on curve25519-dalek/digest themselves.

@jrose-signal jrose-signal added acknowledged awaiting release Will be in the next release of libsignal and removed acknowledged labels Feb 29, 2024
@jrose-signal
Copy link
Contributor

Fixed in v0.41.0.

@kpcyrd
Copy link
Author

kpcyrd commented Mar 1, 2024

cool, thanks! :)

@kpcyrd kpcyrd deleted the usernames-curve25519-dalek-digest branch March 1, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release Will be in the next release of libsignal
Development

Successfully merging this pull request may close these issues.

None yet

2 participants