Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitors/http: support SNI #1903

Merged
merged 2 commits into from
Sep 9, 2021
Merged

monitors/http: support SNI #1903

merged 2 commits into from
Sep 9, 2021

Conversation

tchernomax
Copy link
Contributor

No description provided.

@tchernomax
Copy link
Contributor Author

sorry, I can't build the dev image to generate all the docs and tests:

max@hostname % make image
…
[6/6] STEP 19/23: COPY scripts/patch-interpreter /bin/
--> 9090b4da6f1
[6/6] STEP 20/23: RUN ["/bin/ld-linux.so", "/bin/sh", "/bin/patch-interpreter", "/"]
Setting interpreter on /bin/* to /bin/ld-linux.so
container exited on segmentation fault
Error: error building at STEP "RUN /bin/ld-linux.so /bin/sh /bin/patch-interpreter /": error while running runtime: exit status 1
make: *** [Makefile:87: image] Error 125

@tchernomax tchernomax requested review from a team as code owners September 9, 2021 14:33
Copy link
Contributor

@keitwb keitwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good. I changed the config name to sniServerName to make it clearer what it is for and generated the docs for the config.

@tchernomax
Copy link
Contributor Author

@keitwb thank you

@keitwb keitwb merged commit bc8a781 into signalfx:main Sep 9, 2021
@tchernomax tchernomax deleted the http_sni branch September 9, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants