Skip to content

Commit

Permalink
Remove extraArgs config parameter (#313)
Browse files Browse the repository at this point in the history
With the latest collector releases, all arguments were moved to configuration. And `extraArgs` parameter is already removed from the schema, so it cannot be used since 0.37.0.
  • Loading branch information
dmitryax committed Nov 19, 2021
1 parent a154af5 commit fae282f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ guidelines](https://github.com/signalfx/splunk-otel-collector-chart/blob/main/UP
### Removed

- Busybox image dependency (#275)
- `extraArgs` config parameter (#313)

## [0.37.1] - 2021-11-01

Expand Down
3 changes: 0 additions & 3 deletions helm-charts/splunk-otel-collector/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ spec:
- --config=/conf/relay.yaml
{{- end }}
- --metrics-addr=0.0.0.0:8889
{{- range $agent.extraArgs }}
- {{ . }}
{{- end }}
ports:
{{- range $key, $port := $agent.ports }}
{{- if eq true (and (eq (include "splunk-otel-collector.metricsEnabled" $) "true") (has "metrics" $port.enabled_for)) (and (eq (include "splunk-otel-collector.o11yTracesEnabled" $) "true") (has "traces" $port.enabled_for)) (and (eq (include "splunk-otel-collector.logsEnabled" $) "true") (has "logs" $port.enabled_for)) }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ spec:
- --config=/conf/relay.yaml
{{- end }}
- --metrics-addr=0.0.0.0:8889
{{- range $clusterReceiver.extraArgs }}
- {{ . }}
{{- end }}
image: {{ template "splunk-otel-collector.image.otelcol" . }}
imagePullPolicy: {{ .Values.image.otelcol.pullPolicy }}
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,6 @@ spec:
- --config=/conf/relay.yaml
{{- end }}
- --metrics-addr=0.0.0.0:8889
{{- range $gateway.extraArgs }}
- {{ . }}
{{- end }}
image: {{ template "splunk-otel-collector.image.otelcol" . }}
imagePullPolicy: {{ .Values.image.otelcol.pullPolicy }}
env:
Expand Down

0 comments on commit fae282f

Please sign in to comment.