Remove extraArgs config parameter #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest collector releases, all arguments were moved to configuration. And `extraArgs` parameter is already removed from the schema, so it cannot be used since 0.37.0.
rockb1017
approved these changes
Nov 19, 2021
|
looks good. one thing, no need to remove from json schema? |
|
I mentioned in the PR comment that it was already removed some time ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest collector releases, all arguments were moved to configuration. And
extraArgsparameter is already removed from the schema, so it cannot be used since 0.37.0.