[agent] change the default journald directory #1110
Conversation
atoulme
force-pushed
the
change_default_journald_directory
branch
from
c8e7454
to
c179f4c
Compare
| # Please update directory path for journald if it's different from below default value "/var/log/journal" | ||
| directory: /var/log/journal | ||
| # Please update directory path for journald if it's different from below default value "/run/log/journal" | ||
| directory: /run/log/journal |
There was a problem hiding this comment.
Why would we need to specify a value to begin with?
There was a problem hiding this comment.
oh true, the default value can be an empty string.
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/0d4683eb03d3f1aebb427fa094e0baff638deab6/pkg/stanza/operator/input/journald/journald.go#L101 empty string would still cause setting the --directory option so I think leaving the field commented would be preferable?
There was a problem hiding this comment.
missed that this is required for volume, so deferring to node default isn't possible as is (which answers my question).
There was a problem hiding this comment.
understood, I'll revert and use the /run/log/journal then.
atoulme
force-pushed
the
change_default_journald_directory
branch
from
d931f7d
to
b2aa040
Compare
This reverts commit b2aa040.
Description:
Change the default journald directory to match the default of the receiver:
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/journaldreceiver