Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receiver:k8scluster dimension to k8s cluster metrics #134

Merged
merged 1 commit into from
May 21, 2021

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented May 11, 2021

No description provided.

@jrcamp jrcamp requested review from dmitryax and mstumpfx May 11, 2021 21:51
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@mstumpfx
Copy link
Contributor

I wonder if there’s a more useful / better identifier dimension we could use instead of unused:1? If we're adding a new global dimension, might as well make it something more useful? Maybe something like agent_version or something along those lines?

@jrcamp
Copy link
Contributor Author

jrcamp commented May 12, 2021

I wonder if there’s a more useful / better identifier dimension we could use instead of unused:1? If we're adding a new global dimension, might as well make it something more useful? Maybe something like agent_version or something along those lines?

agent_version would be useful but we don't want these MTS to churn every time they upgrade though :( Also it's only for k8s metrics. There's probably something that's better but I lack imagination to think of it.

@jrcamp jrcamp requested review from a team as code owners May 21, 2021 20:13
@jrcamp jrcamp changed the title Add unused dimension to k8s cluster metrics Add receiver:k8scluster dimension to k8s cluster metrics May 21, 2021
@jrcamp jrcamp merged commit fd6fb18 into signalfx:main May 21, 2021
@jrcamp jrcamp deleted the unused branch May 21, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants