Automatically detect container runtime and apply relevant parsing config #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
auto-detect-runtime
branch
2 times, most recently
from
d89a8bf
to
fd9d08a
Compare
This change makes transition from deprecated docker to containerd runtime not disruptive. Otherwise, users have to change criTimeFormat property and upgrade the chart release after k8s cluster upgrade to version 1.22.
dmitryax
force-pushed
the
auto-detect-runtime
branch
from
fd9d08a
to
60e4b63
Compare
helm-charts/splunk-otel-collector/templates/configmap-fluentd-cri.yaml
Outdated
Show resolved
Hide resolved
rmfitzpatrick
approved these changes
May 28, 2021
…cri.yaml Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
dmitryax
force-pushed
the
auto-detect-runtime
branch
from
e15a365
to
9557d99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes transition from deprecated docker to containerd runtime not disruptive.
Otherwise, users have to change criTimeFormat property and upgrade the chart release after k8s cluster upgrade to version 1.22.
I'll run
make renderonce it's reviewed to avoid auto-generated changed and make it easier for reviewers. For now let pre-commit failing