Add validation of required parameters #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaderer
approved these changes
Oct 15, 2021
Add the following JSON Schema rules: - Required fields of any of the destinations must be filled - A destination (`splunkPlatform` or `splunkObservability`) must have at least one of the telemetry types enabled
dmitryax
force-pushed
the
validate-required-attributes
branch
2 times, most recently
from
2dd250a
to
84bfcc4
Compare
dmitryax
force-pushed
the
validate-required-attributes
branch
from
84bfcc4
to
9924406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following JSON Schema rules:
splunkPlatformandsplunkObservability) must have at least one of the telemetry types enabledTODO in the following PR: rely only on
splunkPlatform.endpointandsplunkObservability.realmto determine which destination is enabled, and requiresplunkPlatform.tokenandsplunkObservability.accessTokenfor any enabled destination.