Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTL-1409 Add support for Operator based Java auto-instrumentation #701

Merged
merged 18 commits into from
Apr 17, 2023

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Mar 21, 2023

Description:

  • With these changes I am proposing to add Operator based Java auto-instrumentation to this Helm chart as an experimental feature.
  • Most of the rendered manifests can be ignored, I suggest only looking at the rendered manifests under the operator subdirectory. They are the only ones containing original content that is being added.
  • The example and documentation being added only shows how to configure auto-instrumentation for a single and simple happy path use case. There are other ways we could setup auto-instrumentation that we should document in the future.
  • More follow up PRs are to come.

New Documentation Links:

Testing:

  • Tested locally and manually with the following specs.
    • minikube v1.29.0 on Darwin 13.2.1
    • hyperkit driver
    • Resources CPUs=4, Memory=8192MB, Disk=20000MB

@jvoravong
Copy link
Contributor Author

Thanks for the feedback @rmfitzpatrick. I have met with several others I work with and have received excellent feedback. More changes coming soon.

@jvoravong jvoravong changed the title OTL-1409 Add experimental support for Operator based Java auto-instrumentation OTL-1409 Add support for Operator based Java auto-instrumentation Apr 4, 2023
…ith it for Operator based Java auto-instrumentation
@jvoravong jvoravong force-pushed the OTL-1409 branch 3 times, most recently from 75f12cd to f2f8ed2 Compare April 4, 2023 22:42
…n-introduction.md, auto-instrumentation-install.md
@jvoravong jvoravong marked this pull request as ready for review April 4, 2023 23:01
@jvoravong jvoravong requested review from a team as code owners April 4, 2023 23:01
ci_scripts/setup_cert_manager.sh Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
@jvoravong jvoravong requested a review from dmitryax April 7, 2023 02:08
docs/auto-instrumentation-introduction.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
jvoravong and others added 2 commits April 10, 2023 08:20
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, otherwise LGTM

.gitignore Show resolved Hide resolved
docs/auto-instrumentation-install.md Outdated Show resolved Hide resolved
@jvoravong jvoravong merged commit 9d9c089 into signalfx:main Apr 17, 2023
@jvoravong jvoravong deleted the OTL-1409 branch April 17, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants