Fix k8s.cluster.name resource attribute for logs in GCP
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
fix-k8s-cluster-name-gcp
branch
from
31e9e43
to
0eb2723
Compare
Following the merge of signalfx#660, the `resource` processor in the logs pipeline was placed before the `resourcedetection` processor. In contrast, the other pipelines have the `resource` processor after the `resourcedetection` processor. This order is crucial in GCP because the `resourcedetection` processor's `gcp` detector sets the `k8s.cluster.name` attribute, which we then override with the user-provided value in the `resource` processor. By keeping the `resource` processor after the `resourcedetection` processor, we ensure that any `k8s.cluster.name` attribute is always set with the user-provided value. This change was implemented to ensure that the order of processors is consistent across all pipelines, guaranteeing that the `k8s.cluster.name` attribute is always set to the value provided in the `clusterName` field of the values.yaml file.
dmitryax
force-pushed
the
fix-k8s-cluster-name-gcp
branch
from
0eb2723
to
35cbd5b
Compare
crobert-1
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#660 changed the order of
resourcedetectionandresourceprocessors in the logs pipeline, while the other pipelines were unchanged. This order is crucial because theresourcedetectionprocessor'sgcpdetector sets thek8s.cluster.nameattribute, which we then override with the user-provided value in theresourceprocessor. By keeping theresourceprocessor after theresourcedetectionprocessor, we ensure thatk8s.cluster.nameattribute is always set with the user-provided value.This change ensures that the order of processors is consistent across all pipelines, guaranteeing that the
k8s.cluster.nameattribute is always set to the value provided in theclusterNamefield of the values.yaml file.