Add ServiceAccountName to secret-splunk-validation-hook pod #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was not sure if I was suppose to follow the RELEASE.md instructions for this PR. I can update the PR it its suppose to be a part of this. |
|
@philipsabri thanks for finding and contributing a fix for this. My team runs the release process about every 2 weeks, nothing has to be done by you. |
philipsabri
force-pushed
the
add-SA-hook-pod
branch
from
9ce4d40
to
d9c1215
Compare
Entry added to CHANGELOG.md Thanks for quick response 👍 |
philipsabri
force-pushed
the
add-SA-hook-pod
branch
from
d9c1215
to
65ae9ab
Compare
|
Updated with a fix 🤞 for the changelog test |
jvoravong
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ServiceAccountName to secret-splunk-validation-hook pod
Fixes #780