Fix secret name conflicts

[VihasMakwana]

Fixes #439.

[jinja2]

Suggested change

	{{ $name := (include "splunk-otel-collector.name" .) -}}
	{{- if contains $name .Release.Name -}}
	{{- .Release.Name | trunc 63 | trimSuffix "-" -}}
	{{- else -}}
	{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}}
	{{- end -}}
	{{ default (include "splunk-otel-collector.fullname" .) .Values.secret.name }}

I think you can just replace directly with the helper function, and can also remove the if/else before this. splunk-otel-collector.fullname already evaluates the same conditions with the addition of also respecting the fullNameOverride variable which is missing here.

[VihasMakwana]

@jinja2 I took a look and it turns out I over-complicated the changes. Please have a look at my latest changes, they're quite simple than before and easy to understand.

[dmitryax]

@VihasMakwana please run make render

[VihasMakwana]

@dmitryax I think we are good to merge.