Enable batch for metrics #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use default config for batch (send every 200ms or 8192 items). This is same that https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/config/collector/gateway_config.yaml is using. Resolves signalfx#32
dmitryax
reviewed
Apr 12, 2021
| @@ -111,8 +111,6 @@ processors: | |||
| {{- include "splunk-otel-collector.otelMemoryLimiterConfig" .Values.otelAgent | nindent 2 }} | |||
|
|
|||
| batch: | |||
There was a problem hiding this comment.
I remember facing issues with null values in helm. Can we set batch: {} instead?
There was a problem hiding this comment.
AFAIR you cannot override them in user's values files. Feel free to try, I may be wrong
There was a problem hiding this comment.
Seems to work fine merging in values from otelAgent.processors.batch. We do the same thing with zpages extension that was already there so I think you're thinking of a different issue.
There was a problem hiding this comment.
I think you might be thinking of a situation where in values.yaml we had to do foo: {} instead of foo: due to some reason.
There was a problem hiding this comment.
Ok, maybe. I don't remember exact reason
dmitryax
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use default config for batch (send every 200ms or 8192 items). This is same
that
https://github.com/signalfx/splunk-otel-collector/blob/main/cmd/otelcol/config/collector/gateway_config.yaml
is using.
Resolves #32