Use signalfx-forwarder in default agent trace pipeline #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
reviewed
Apr 15, 2021
| @@ -57,6 +57,9 @@ receivers: | |||
| extra_metadata_labels: | |||
| - container.id | |||
|
|
|||
| smartagent/signalfx-forwarder: | |||
| type: signalfx-forwarder | |||
|
|
|||
There was a problem hiding this comment.
Should listenAddress also be configured to match the default agent config (0.0.0.0:9080)?
There was a problem hiding this comment.
I wasn't sure tbh since this isn't in the SA config map, but if that's the default everything else uses makes sense.
rmfitzpatrick
force-pushed
the
add_sfx_forwarder
branch
from
3393274
to
12c639b
Compare
asuresh4
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added to the default agent config, so adopting here