Remove by default empty allowedFlexVolumes #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
The change lgtm but please sign the CLA, run |
|
I have read the CLA Document and I hereby sign the CLA |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Oct 27, 2023
From make render
|
@jinja2, this should now be done, thanks |
jinja2
reviewed
Oct 30, 2023
jinja2
reviewed
Oct 30, 2023
jinja2
reviewed
Oct 31, 2023
jinja2
reviewed
Oct 31, 2023
jinja2
reviewed
Oct 31, 2023
jinja2
approved these changes
Oct 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It fixes an issue where an ArgoCD Application syncs the helm chart with the default SCC enabled. The ArgoCD application is always out of sync due to
allowedFlexVolumesbeing empty on the cluster but being defined in Git.This is actually expected due to the specifications [0] with
omitempty.The proposal is to remove the
allowedFlexVolumesfield since it does not provide any default additional benefits for the users.Testing:
Tested on an OpenShift cluster 4.13. The ArgoCD Application is no longer out of sync and there is no impact.
Documentation:
[0] https://github.com/openshift/api/blob/release-4.13/security/v1/types.go#L79