Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vale linter github action #2089

Closed
wants to merge 1 commit into from
Closed

Add vale linter github action #2089

wants to merge 1 commit into from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 7, 2022

No description provided.

@atoulme atoulme force-pushed the vale_linter branch 9 times, most recently from 901e4a0 to 8c1633f Compare October 7, 2022 06:16
path: vale-splunk-style-guide

- run: |
cat <<EOF > .vale.ini
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Vale ini in conflict with the StylesPath below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't follow. What are you referring to?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how the setup works for a pipeline/action, but, essentially, the .vale.ini file already contains the path to styles. The path in the file must match whatever path in the local filesystem. Wondering if that's the cause for the pipeline not to work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try entering a nonsensical path and see if it gets picked up.

.github/workflows/vale.yml Show resolved Hide resolved
@atoulme atoulme closed this Nov 2, 2022
@atoulme atoulme deleted the vale_linter branch November 8, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants