Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct module names for directory locations in examples #2665

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

evantorrie
Copy link
Contributor

This is required for "multimod" tool utility to stop complaining about incorrectly named modules.

Moreover, it's just better practice to name the module after the git repo + module subpath

This is required for "multimod" tool utility to stop complaining
@evantorrie evantorrie requested review from a team as code owners March 6, 2023 05:57
@dmitryax dmitryax merged commit 6acfecd into signalfx:main Mar 6, 2023
@evantorrie evantorrie deleted the example-module-names branch March 6, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants