[receiver/lightprometheus] OTL-2117: Limit resource attributes #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
make-lightprom-attrs-configurable
branch
2 times, most recently
from
42e5de1
to
17a00f6
Compare
atoulme
approved these changes
May 1, 2023
|
Linting issues - looks like they predate your changes, sorry. Please apply fixes. |
Limit resource attributes added by the lightprometheus receiver by default and make them configurable.
Make enabling/disabling particular attributes possible and disable the following attributes by default:
- net.host.name:
- net.host.port:
- http.scheme:
To enable them back the attributes add the following configuration:
```yaml
resource_attributes:
net.host.name:
enabled: true
net.host.port:
enabled: true
http.scheme:
enabled: true
```
dmitryax
force-pushed
the
make-lightprom-attrs-configurable
branch
from
17a00f6
to
f34755a
Compare
rmfitzpatrick
approved these changes
May 1, 2023
|
@rmfitzpatrick, added readme, PTAL #3049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit resource attributes added by the lightprometheus receiver by default and make them configurable.
Make enabling/disabling particular attributes possible and disable the following attributes by default:
To enable them back the attributes add the following configuration:
The configuration interface is aligned with receivers created by the mdatagen tool