Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper config source #318

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Zookeeper config source #318

merged 2 commits into from
Apr 23, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Apr 21, 2021

No description provided.

@owais owais requested a review from pjanotti April 21, 2021 23:13
@owais owais force-pushed the zookeeper-config-source branch 2 times, most recently from 2a68986 to 82c2534 Compare April 21, 2021 23:19
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #318 (f17328c) into main (80d32ed) will increase coverage by 0.14%.
The diff coverage is 76.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   79.10%   79.24%   +0.14%     
==========================================
  Files          30       33       +3     
  Lines        2240     2313      +73     
==========================================
+ Hits         1772     1833      +61     
- Misses        423      434      +11     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...configsource/zookeeperconfigsource/configsource.go 0.00% <0.00%> (ø)
...rnal/configsource/zookeeperconfigsource/session.go 88.57% <88.57%> (ø)
...rnal/configsource/zookeeperconfigsource/factory.go 100.00% <100.00%> (ø)
internal/configprovider/helpers.go 81.81% <0.00%> (+45.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d32ed...f17328c. Read the comment docs.

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nits and a suggestion about a README.md, see #317 (comment)

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor typo on the README.md

internal/configsource/zookeeperconfigsource/README.md Outdated Show resolved Hide resolved
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
@owais owais requested a review from pjanotti April 22, 2021 15:41
@owais owais merged commit f5d4e2c into main Apr 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the zookeeper-config-source branch April 23, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants